-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(managers/custom): introduce customType
field
#23919
feat(managers/custom): introduce customType
field
#23919
Conversation
Co-authored-by: Anne Stellingwerf <[email protected]>
Co-authored-by: Michael Kriese <[email protected]>
…ngh/renovate into feat/custom-syntax
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the customType default is regex, why do we need to migrate configs to include it?
It's not default |
@viceice @secustor we have a choice between these:
I think I'd prefer to keep it simple with (1) unless you think there's too much confusion? |
I would prefer 2 as it is more verbose and signals to new or users with limited exposure that there are more options. This is IMO not comparable to |
🎉 This PR is included in version 36.56.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Renovate introduced a new `customType` field that needed config migration, see: - https://github.com/renovatebot/renovate/releases/tag/36.56.0 - renovatebot/renovate#23919 Signed-off-by: Mahe Tardy <[email protected]>
Renovate introduced a new `customType` field that needed config migration, see: - https://github.com/renovatebot/renovate/releases/tag/36.56.0 - renovatebot/renovate#23919 Signed-off-by: Mahe Tardy <[email protected]>
Renovate introduced a new `customType` field that needed config migration, see: - https://github.com/renovatebot/renovate/releases/tag/36.56.0 - renovatebot/renovate#23919 Signed-off-by: Mahe Tardy <[email protected]>
Changes
customType
field to custom manager configRegExManager
toCustomManager
customType
customType: 'regex'
Context
Part of #19066
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: