Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(managers/custom): introduce customType field #23919

Merged
merged 21 commits into from
Aug 22, 2023

Conversation

RahulGautamSingh
Copy link
Collaborator

@RahulGautamSingh RahulGautamSingh commented Aug 17, 2023

Changes

  • add customType field to custom manager config
  • Rename RegExManager to CustomManager
  • Add migration and validation code for customType
  • Update regexManager presets to include customType: 'regex'

Context

Part of #19066

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

docs/usage/configuration-options.md Outdated Show resolved Hide resolved
docs/usage/configuration-options.md Outdated Show resolved Hide resolved
lib/config/options/index.ts Outdated Show resolved Hide resolved
docs/usage/configuration-options.md Outdated Show resolved Hide resolved
lib/config/validation.spec.ts Show resolved Hide resolved
lib/config/migrations/custom/regex-managers-migration.ts Outdated Show resolved Hide resolved
docs/usage/configuration-options.md Outdated Show resolved Hide resolved
lib/config/types.ts Outdated Show resolved Hide resolved
lib/config/options/index.ts Outdated Show resolved Hide resolved
lib/config/migrations/custom/regex-managers-migration.ts Outdated Show resolved Hide resolved
lib/config/types.ts Outdated Show resolved Hide resolved
can't do proper union since no other custom  managers present
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the customType default is regex, why do we need to migrate configs to include it?

@RahulGautamSingh
Copy link
Collaborator Author

If the customType default is regex, why do we need to migrate configs to include it?

It's not default regex atm

@rarkins
Copy link
Collaborator

rarkins commented Aug 22, 2023

@viceice @secustor we have a choice between these:

  1. Default to regex manager
  • This makes regex the "preferred" custom manager forever (similar to platform=github)
  • No migration necessary for existing configs
  1. Require regex manager
  • Requires migration PRs for every existing config
  • Still makes regex the preferred custom manager because anyone leaving it off gets it migrated

I think I'd prefer to keep it simple with (1) unless you think there's too much confusion?

@secustor
Copy link
Collaborator

I would prefer 2 as it is more verbose and signals to new or users with limited exposure that there are more options.

This is IMO not comparable to platform=github as this is a self-hosted option and not an actual option an user would interact much with.
Thinking here of bigger deployments.

@rarkins rarkins added this pull request to the merge queue Aug 22, 2023
Merged via the queue into renovatebot:main with commit 0613c24 Aug 22, 2023
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 36.56.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

mtardy added a commit to cilium/tetragon that referenced this pull request Sep 14, 2023
Renovate introduced a new `customType` field that needed config
migration, see:
- https://github.com/renovatebot/renovate/releases/tag/36.56.0
- renovatebot/renovate#23919

Signed-off-by: Mahe Tardy <[email protected]>
mtardy added a commit to cilium/tetragon that referenced this pull request Sep 14, 2023
Renovate introduced a new `customType` field that needed config
migration, see:
- https://github.com/renovatebot/renovate/releases/tag/36.56.0
- renovatebot/renovate#23919

Signed-off-by: Mahe Tardy <[email protected]>
kkourt pushed a commit to cilium/tetragon that referenced this pull request Sep 15, 2023
Renovate introduced a new `customType` field that needed config
migration, see:
- https://github.com/renovatebot/renovate/releases/tag/36.56.0
- renovatebot/renovate#23919

Signed-off-by: Mahe Tardy <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants