Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: autoreplace support for replacements #13211

Closed
wants to merge 2 commits into from
Closed

feat: autoreplace support for replacements #13211

wants to merge 2 commits into from

Conversation

JamieMagee
Copy link
Contributor

@JamieMagee JamieMagee commented Dec 21, 2021 •
edited
Loading

Changes:

Adds support for replacements for autoreplace managers

Context:

Affected managers:

  • ansible
  • ansible-galaxy
  • argocd
  • azure-pipelines
  • batect
  • batect-wrapper
  • bitbucket-pipelines
  • buildkite
  • bundler
  • cake
  • cargo
  • cdnurl
  • circleci
  • cloudbuild
  • cocoapods
  • composer
  • deps-edn
  • docker-compose
  • dockerfile
  • droneci
  • github-actions
  • gitlabci
  • gitlabci-include
  • gradle-wrapper
  • helm-requirements
  • helm-values
  • helmfile
  • helmsman
  • helmv3
  • html
  • jenkins
  • jsonnet-bundler
  • kubernetes
  • kustomize
  • leiningen
  • meteor
  • mix
  • nodenv
  • nuget
  • nvm
  • pip-compile
  • pip_requirements
  • pip_setup
  • pipenv
  • poetry
  • pre-commit
  • pub
  • pyenv
  • ruby-version
  • sbt
  • setup-cfg
  • swift
  • terraform
  • terraform-version
  • terragrunt
  • terragrunt-version
  • travis

Closes #12623

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@HonkingGoose
Copy link
Collaborator

Sweet! Happy to help try things out, just ping me on the PR!

@fgreinacher here's your ping! 😉

@astellingwerf
Copy link
Collaborator

Do you intend to add a warning if replacement is attempted on the other (not yet supporting) managers?

@JamieMagee JamieMagee force-pushed the feat/autoreplace-replacements branch from 21df869 to d7a9bad Compare December 24, 2021 00:49
JamieMagee added a commit that referenced this pull request Dec 24, 2021
@JamieMagee
chore: log warning for managers which don't support replacements
364f6d5 
#13211 (comment)
@JamieMagee JamieMagee mentioned this pull request Dec 24, 2021
Merged
6 tasks
@JamieMagee
Copy link
Contributor Author

Do you intend to add a warning if replacement is attempted on the other (not yet supporting) managers?

Good idea. I opened #13276

@JamieMagee JamieMagee force-pushed the feat/autoreplace-replacements branch from d7a9bad to aa0edc6 Compare December 27, 2021 01:00
JamieMagee added a commit that referenced this pull request Jan 10, 2022
@JamieMagee @astellingwerf
chore: log warning for managers which don't support replacements
23d6f1b 
#13211 (comment)

Apply suggestions from code review

Co-authored-by: Anne Stellingwerf <[email protected]>
JamieMagee added a commit that referenced this pull request Jan 14, 2022
@JamieMagee @astellingwerf
chore: log warning for managers which don't support replacements
883b244 
#13211 (comment)

Apply suggestions from code review

Co-authored-by: Anne Stellingwerf <[email protected]>
@JamieMagee JamieMagee mentioned this pull request Feb 11, 2022
Closed
12 tasks
@ritazh
Copy link

ritazh commented May 5, 2022 •
edited
Loading

@nilekhc FYI https://github.com/renovatebot/renovate/pull/13211/files#diff-361f8e997d2363b61f0820b49d95385ba72d989824436cc364f90b576ef88ba8R175-R179

@JamieMagee JamieMagee force-pushed the feat/autoreplace-replacements branch from aa0edc6 to f2459b2 Compare May 27, 2022 04:31
@JamieMagee
Copy link
Contributor Author

Rebased on top of current main. Will finalise these changes in the next couple of days.

@JamieMagee JamieMagee force-pushed the feat/autoreplace-replacements branch 3 times, most recently from 280d015 to bb39d07 Compare May 31, 2022 04:47
@JamieMagee JamieMagee force-pushed the feat/autoreplace-replacements branch from bb39d07 to 6870bb1 Compare June 2, 2022 00:13
@JamieMagee JamieMagee marked this pull request as ready for review June 2, 2022 00:13
@rarkins
Copy link
Collaborator

rarkins commented Jun 2, 2022

Any demo repos?

@JamieMagee
Copy link
Contributor Author

Any demo repos?

I've mostly been testing Docker recently. I'll extend the test suite out to cover more managers https://github.com/JamieMagee/renovate-replacements-docker

I would like to test at least 10.

@rarkins rarkins marked this pull request as draft June 22, 2022 09:44
@JamieMagee JamieMagee dismissed a stale review via a5d8ef1 June 30, 2022 20:48
@chezsmithy
Copy link
Contributor

Would you like some help with this PR? Happy to help create some test repos, or write some tests?

@setchy
Copy link
Collaborator

setchy commented Jul 29, 2022

Very eager for this enhancement, particularly for docker. I have quite a lot of images that need migrating

This was referenced Aug 29, 2022
Closed
Closed
@JamieMagee
Copy link
Contributor Author

Closing in favour of #17476

@JamieMagee JamieMagee closed this Aug 30, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2022
@JamieMagee JamieMagee deleted the feat/autoreplace-replacements branch October 7, 2022 06:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replacing deprecated dependencies for docker datasource only replace version
7 participants
@JamieMagee @HonkingGoose @astellingwerf @ritazh @rarkins @chezsmithy @setchy