Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config): add replacement presets for pypi packages #12712

Closed
wants to merge 4 commits into from
Closed

feat(config): add replacement presets for pypi packages #12712

wants to merge 4 commits into from

Conversation

wwuck
Copy link
Contributor

@wwuck wwuck commented Nov 17, 2021 •
edited
Loading

Changes:

https://pypi.org/project/flake8-pathlib/ was renamed to https://pypi.org/project/flake8-use-pathlib/
https://pypi.org/project/svg.elements/ was renamed to https://pypi.org/project/svgelements/

Context:

The flake8-pathlib package on PyPI was renamed to flake8-use-pathlib.
The svg.elements package on PyPI was renamed to svgelements.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@wwuck wwuck changed the title feat: add replacement preset for flake8-pathlib feat(config): add replacement preset for flake8-pathlib Nov 17, 2021
@rarkins
Copy link
Collaborator

rarkins commented Nov 17, 2021

I thought the replace capabilities only support npm today? Cc @JamieMagee

@JamieMagee
Copy link
Contributor

I thought the replace capabilities only support npm today? Cc @JamieMagee

Correct, but I haven't finished #12626.

IMO this PR is still valuable, and will light up scenarios once we do have pypi support. Once we merge support in autoReplace we'll light up ~75% of datasources, including pypi.

JamieMagee
JamieMagee previously approved these changes Nov 21, 2021
View reviewed changes
Copy link
Contributor

@JamieMagee JamieMagee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work right now, but I am happy merging this in the meantime.

@rarkins
Copy link
Collaborator

rarkins commented Nov 22, 2021

This won't work right now, but I am happy merging this in the meantime.

Don't you think it will lead to people raising a bug for why it's not working?

@viceice viceice marked this pull request as draft November 22, 2021 07:57
@viceice
Copy link
Member

viceice commented Nov 22, 2021

lets leave this as draft until it's supported

@HonkingGoose HonkingGoose added the status:blocked Issue is blocked by another issue or external requirement label Nov 22, 2021
@wwuck wwuck changed the title feat(config): add replacement preset for flake8-pathlib feat(config): add replacement presets for pypi packages Dec 12, 2021
@rarkins
Copy link
Collaborator

rarkins commented Apr 28, 2022

Let's reopen once it's unblocked

@rarkins rarkins closed this Apr 28, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@HonkingGoose HonkingGoose HonkingGoose left review comments

@JamieMagee JamieMagee JamieMagee left review comments

Assignees
No one assigned
Labels
status:blocked Issue is blocked by another issue or external requirement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wwuck @rarkins @JamieMagee @viceice @HonkingGoose