Skip to content
This repository has been archived by the owner on Feb 9, 2024. It is now read-only.

Current docker image ships a broken poetry installation #366

Closed
languitar opened this issue Nov 2, 2021 · 6 comments
Closed

Current docker image ships a broken poetry installation #366

languitar opened this issue Nov 2, 2021 · 6 comments

Comments

@languitar
Copy link

How are you running Renovate?

Self-hosted

Please select which platform you are using if self-hosting.

No response

If you're self-hosting Renovate, tell us what version of Renovate you run.

v28.20.0

Describe the bug

Recent Docker images contain a version of CacheControl inside the venv containing poetry that renders poetry unusable in some cases. The respective upstream bugs in poetry and CacheControl are python-poetry/poetry#4688 and psf/cachecontrol#263.

To make poetry usable again in all cases, a temporary workaround inside the docker image of renovate would be needed that downgrades CacheControl inside the poetry venv as proposed in the first issue.

Relevant debug logs

No response

Have you created a minimal reproduction repository?

No reproduction repository

@rarkins
Copy link
Contributor

rarkins commented Nov 2, 2021

Thanks for the heads-up, although it's not something we can fix here so I will close this issue.

The full image is built here: https://github.com/renovatebot/docker-renovate-full

And that is built using scripts from https://github.com/containerbase/buildpack

As I'm not familiar with CacheControl so not sure where would be best to raise a fix. If you can work it out, can you raise an issue in the correct repo?

@rarkins rarkins closed this as completed Nov 2, 2021
@languitar
Copy link
Author

Sorry, I didn't know about that repository. Can you transfer this issue to the correct repository. I can try to come up with a fix then.

@rarkins rarkins transferred this issue from renovatebot/renovate Nov 2, 2021
@rarkins rarkins reopened this Nov 2, 2021
@rarkins
Copy link
Contributor

rarkins commented Nov 2, 2021

I have transferred and reopened it, although as I mentioned the fix might need to be e.g. in https://github.com/containerbase/buildpack/blob/main/src/usr/local/buildpack/tools/poetry.sh which is a different github org so can't be transferred to

languitar added a commit to languitar/docker-renovate-full that referenced this issue Nov 2, 2021
As a temporary measure to work around python-poetry/poetry#4688, downgrade CacheControl in the poetry virtualenv to a working version.

This fixes renovatebot#366
languitar added a commit to languitar/docker-renovate-full that referenced this issue Nov 2, 2021
As a temporary measure to work around python-poetry/poetry#4688, downgrade CacheControl in the poetry virtualenv to a working version.

This fixes renovatebot#366
@languitar
Copy link
Author

I have transferred and reopened it, although as I mentioned the fix might need to be e.g. in https://github.com/containerbase/buildpack/blob/main/src/usr/local/buildpack/tools/poetry.sh which is a different github org so can't be transferred to

I'm not sure how far this should traverse the dependency tree. #367 would solve this at least for the renovate docker image.

@viceice
Copy link
Member

viceice commented Nov 4, 2021

this is now fixed by composer update #368, as composer is before poetry, so it invalidates cache.

@viceice viceice closed this as completed Nov 4, 2021
@viceice
Copy link
Member

viceice commented Nov 4, 2021

fixed versions: 28.20.1, 28.20.2, 28.21.0, 28.21.1, 28.21.2, 28.21.3, 28.21.4, 28.21.5, 28.21.6, 28.21.7

@viceice viceice pinned this issue Nov 4, 2021
@rarkins rarkins unpinned this issue Dec 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants