order: include worst case price #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sehyunc
force-pushed
the
sehyun/worst-case-price
branch
from
cf810c9 to
fd4705c
Compare
sehyunc
force-pushed
the
sehyun/worst-case-price
branch
from
fd4705c to
96fe0fd
Compare
sehyunc
force-pushed
the
sehyun/worst-case-price
branch
from
96fe0fd to
b01cc19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps the SDK to a version that supports specifying the worst case price for safety. It sets a default worst case price of 50% of the Binance price for sell orders, and 150% for buy orders.
Tested using the frontend by buying / selling all available tokens and ensuring that I received a fill for each.