Skip to content

Commit

Permalink
roachtest: mark failures in cluster.Install as transient
Browse files Browse the repository at this point in the history
This function only runs a fixed set of installation commands. If they
fail, we create an issue assigned to Test Eng and label the issue as
an infra flake.

Informs: cockroachdb#103316

Release note: None
  • Loading branch information
renatolabs committed Apr 11, 2024
1 parent 0a9ae57 commit a126f17
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion pkg/roachprod/install/install.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import (
"io"
"sort"

rperrors "github.com/cockroachdb/cockroach/pkg/roachprod/errors"
"github.com/cockroachdb/cockroach/pkg/roachprod/logger"
)

Expand Down Expand Up @@ -194,5 +195,9 @@ func InstallTool(
}
// Ensure that we early exit if any of the shell statements fail.
cmd = "set -exuo pipefail;" + cmd
return c.Run(ctx, l, stdout, stderr, WithNodes(nodes), "installing "+softwareName, cmd)
if err := c.Run(ctx, l, stdout, stderr, WithNodes(nodes), "installing "+softwareName, cmd); err != nil {
return rperrors.TransientFailure(err, "install_flake")
}

return nil
}

0 comments on commit a126f17

Please sign in to comment.