New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed some problems in the build system and model download system #131

Merged

remsky merged 2 commits into remsky:master from fireblade2534:build-and-model-system-improvements

Feb 7, 2025

Collaborator

fireblade2534 commented Feb 7, 2025

Build system:

When running the docker compose CPU image it would download Nvidia GPU packages everytime at startup (It did not cache but I just prevented that anyway)

Download system:

Setting env DOWNLOAD_MODEL=true would not download the model when using the default docker compose
The help message telling the user how to download the model would not actually show
The help message gave an invalid command arg (--version)

fireblade2534 added 2 commits

February 7, 2025 18:30


          fixed some problems in the build system and model download system

90f168f


          fixed test case

429c959

remsky approved these changes

View reviewed changes

remsky merged commit 50a211f into remsky:master

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet