fix factory used for repeatable subcommands #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the factory should be passed when creating a CommandSpec copy
Codecov Report
@@ Coverage Diff @@
## master #1100 +/- ##
=========================================
Coverage 94.44% 94.44%
Complexity 448 448
=========================================
Files 2 2
Lines 6607 6607
Branches 1774 1774
=========================================
Hits 6240 6240
Misses 96 96
Partials 271 271
Continue to review full report at Codecov.
|
|
Merged into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the factory should be passed when creating a CommandSpec copy and not degrade to the DefaultFactory