Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update version for release (pre) #21

Merged
merged 3 commits into from
May 24, 2023
Merged

chore: Update version for release (pre) #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
534a80f
chore: Update version for release (pre)
github-actions[bot] May 24, 2023
bd718da
Update changelog
brophdawg11 May 24, 2023
50795ce
Update changelog
brophdawg11 May 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .changeset/pre.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,7 @@
"@remix-run/v1-meta": "0.1.1",
"@remix-run/v1-route-convention": "0.1.1"
},
"changesets": []
"changesets": [
"sibling-pathless-routes"
]
}
6 changes: 5 additions & 1 deletion .changeset/sibling-pathless-routes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,8 @@
"@remix-run/v1-route-convention": patch
---

Allow sibling pathless layout routes (from https://github.com/remix-run/remix/pull/4421)
- Fix route ranking bug with pathless layout route next to a sibling index route

- Under the hood this is done by removing the trailing slash from all generated `path` values since the number of slash-delimited segments counts towards route ranking so the trailing slash incorrectly increases the score for routes

- Support sibling pathless layout routes by removing pathless layout routes from the unique route path checks in conventional route generation since they inherently trigger duplicate paths
10 changes: 10 additions & 0 deletions packages/v1-route-convention/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,15 @@
# `@remix-run/v1-route-convention`

## 0.1.2-pre.0

### Patch Changes

- Fix route ranking bug with pathless layout route next to a sibling index route ([#20](https://github.com/remix-run/v1-compat-utils/pull/20))

- Under the hood this is done by removing the trailing slash from all generated `path` values since the number of slash-delimited segments counts towards route ranking so the trailing slash incorrectly increases the score for routes

- Support sibling pathless layout routes by removing pathless layout routes from the unique route path checks in conventional route generation since they inherently trigger duplicate paths ([#20](https://github.com/remix-run/v1-compat-utils/pull/20))

## 0.1.1

### Patch Changes
Expand Down
2 changes: 1 addition & 1 deletion packages/v1-route-convention/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@remix-run/v1-route-convention",
"version": "0.1.1",
"version": "0.1.2-pre.0",
"homepage": "https://remix.run",
"bugs": {
"url": "https://github.com/remix-run/v1-compat-utils/issues"
Expand Down