Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: css bundling failing on non-node platforms #6238

Merged
merged 3 commits into from
May 1, 2023
Merged

fix: css bundling failing on non-node platforms #6238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
baaa3fa
fix: don't forward on injects for CSS compiler as it's never loading …
jacob-ebey Apr 28, 2023
2481ffa
be explicit
jacob-ebey Apr 28, 2023
03dfe35
be more explicit
jacob-ebey Apr 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/css-import-non-node-fix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@remix-run/dev": patch
---

don't forward on injects for CSS compiler as it's never loading any JS code and esbuild seems to have a bug with CSS entries + inject
42 changes: 36 additions & 6 deletions packages/remix-dev/compiler/plugins/cssImports.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,26 +30,56 @@ export function cssFilePlugin({
name: "css-file",

async setup(build) {
let buildOps = build.initialOptions;
let {
absWorkingDir,
assetNames,
chunkNames,
conditions,
define,
external,
sourceRoot,
treeShaking,
tsconfig,
format,
loader,
mainFields,
nodePaths,
platform,
publicPath,
target,
} = build.initialOptions;

let postcssProcessor = await getPostcssProcessor({ config });

build.onLoad({ filter: /\.css$/ }, async (args) => {
let { metafile, outputFiles, warnings, errors } = await esbuild.build({
...buildOps,
absWorkingDir,
assetNames,
chunkNames,
conditions,
define,
external,
format,
mainFields,
nodePaths,
platform,
publicPath,
sourceRoot,
target,
treeShaking,
tsconfig,
minify: options.mode === "production",
bundle: true,
minifySyntax: true,
metafile: true,
write: false,
sourcemap: Boolean(options.sourcemap && postcssProcessor), // We only need source maps if we're processing the CSS with PostCSS
splitting: false,
stdin: undefined,
outfile: undefined,
outdir: config.assetsBuildDirectory,
entryNames: buildOps.assetNames,
entryNames: assetNames,
entryPoints: [args.path],
loader: {
...buildOps.loader,
...loader,
".css": "css",
},
plugins: [
Expand Down