Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(guides/data-writes): Fix a couple typos #4625

Merged
merged 3 commits into from
Nov 18, 2022
Merged

docs(guides/data-writes): Fix a couple typos #4625

merged 3 commits into from
Nov 18, 2022

Conversation

mjangir
Copy link
Contributor

@mjangir mjangir commented Nov 17, 2022

Closes: #

  • Docs
  • Tests

Testing Strategy:

@changeset-bot
Copy link

changeset-bot bot commented Nov 17, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: bdc8ce1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Nov 17, 2022

Hi @mjangir,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

machour
machour reviewed Nov 17, 2022
View reviewed changes
machour
machour requested changes Nov 17, 2022
View reviewed changes
Copy link
Collaborator

@machour machour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @mjangir,

Just a little rollback to do for the first fix, and we need you to add yourself to the contributors.yml file (sign the CLA)

Thanks !

@machour machour changed the title Fix typos in the docs docs(guides/data-writes): Fix a couple typos Nov 17, 2022
@machour machour added the docs label Nov 17, 2022
@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Nov 18, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@machour machour merged commit 5d1bbdf into remix-run:main Nov 18, 2022
kentcdodds pushed a commit that referenced this pull request Dec 15, 2022
@mjangir @machour @kentcdodds
docs(guides/data-writes): Fix a couple typos (#4625)
0123e79 
* Fix typos in the docs

* Added git user in contributors.yaml

* Update docs/guides/data-writes.md

Co-authored-by: Mehdi Achour <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machour machour machour approved these changes

Assignees
No one assigned
Labels
CLA Signed docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjangir @machour