feat(remix-server-runtime): use an internal hash for the id in `creat…

…eMemorySessionStorage` (#7227)

.changeset/memory-session-id.md

@@ -0,0 +1,5 @@
+---
+"@remix-run/server-runtime": patch
+---
+
+Update `createMemorySessionStorage` to use an internal hash value instead of an integer for the session `id`

packages/remix-server-runtime/__tests__/sessions-test.ts

@@ -86,6 +86,17 @@ describe("In-memory session storage", () => {
 
     expect(session.get("user")).toEqual("mjackson");
   });
+
+  it("uses random hash keys as session ids", async () => {
+    let { getSession, commitSession } = createMemorySessionStorage({
+      cookie: { secrets: ["secret1"] },
+    });
+    let session = await getSession();
+    session.set("user", "mjackson");
+    let setCookie = await commitSession(session);
+    session = await getSession(getCookieFromSetCookie(setCookie));
+    expect(session.id).toMatch(/^[a-z0-9]{8}$/);
+  });
 });
 
 describe("Cookie session storage", () => {

packages/remix-server-runtime/sessions/memoryStorage.ts

@@ -37,7 +37,6 @@ export const createMemorySessionStorageFactory =
   <Data = SessionData, FlashData = Data>({
     cookie,
   }: MemorySessionStorageOptions = {}): SessionStorage<Data, FlashData> => {
-    let uniqueId = 0;
     let map = new Map<
       string,
       { data: FlashSessionData<Data, FlashData>; expires?: Date }
@@ -46,7 +45,7 @@ export const createMemorySessionStorageFactory =
     return createSessionStorage({
       cookie,
       async createData(data, expires) {
-        let id = (++uniqueId).toString();
+        let id = Math.random().toString(36).substring(2, 10);
         map.set(id, { data, expires });
         return id;
       },