Added better detection for absolute urls in link component (#5286)

remix-run · Feb 7, 2023 · 336242a · 336242a
1 parent 29ca7dc
commit 336242a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/contributors.yml b/contributors.yml
@@ -276,6 +276,7 @@
 - lili21
 - lionotm
 - liranm
+- lkwr
 - lordofthecactus
 - lpsinger
 - lswest

diff --git a/packages/remix-react/components.tsx b/packages/remix-react/components.tsx
@@ -291,8 +291,7 @@ function usePrefetchBehavior(
 let NavLink = React.forwardRef<HTMLAnchorElement, RemixNavLinkProps>(
   ({ to, prefetch = "none", ...props }, forwardedRef) => {
     let isAbsolute =
-      typeof to === "string" &&
-      (/^[a-z+]+:\/\//i.test(to) || to.startsWith("//"));
+      typeof to === "string" && /^(?:[a-z][a-z0-9+.-]*:|\/\/)/i.test(to);
 
     let href = useHref(to);
     let [shouldPrefetch, prefetchHandlers] = usePrefetchBehavior(
@@ -326,8 +325,7 @@ export { NavLink };
 let Link = React.forwardRef<HTMLAnchorElement, RemixLinkProps>(
   ({ to, prefetch = "none", ...props }, forwardedRef) => {
     let isAbsolute =
-      typeof to === "string" &&
-      (/^[a-z+]+:\/\//i.test(to) || to.startsWith("//"));
+      typeof to === "string" && /^(?:[a-z][a-z0-9+.-]*:|\/\/)/i.test(to);
 
     let href = useHref(to);
     let [shouldPrefetch, prefetchHandlers] = usePrefetchBehavior(
-Original file line number
+Diff line change
@@ Expand Up / @@ -276,6 +276,7 @@ @@
     - lili21
     - lionotm
     - liranm
+    - lkwr
     - lordofthecactus
     - lpsinger
     - lswest
@@ Expand Down @@