Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change badge style #12931

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Change badge style #12931

merged 2 commits into from
Feb 3, 2025

Conversation

esadek
Copy link
Contributor

@esadek esadek commented Feb 1, 2025

Change npm badge style for consistency.

Before:
image

After:
image

Copy link

changeset-bot bot commented Feb 1, 2025

⚠️ No Changeset found

Latest commit: d5e0209

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Feb 1, 2025

Hi @esadek,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@timdorr
Copy link
Member

timdorr commented Feb 1, 2025

Shouldn't they both be flat-square (or just square)?

@esadek
Copy link
Contributor Author

esadek commented Feb 1, 2025

Shouldn't they both be flat-square (or just square)?

Can make them both square if preferred. Just think they should be the same style whatever that style may be.

@esadek
Copy link
Contributor Author

esadek commented Feb 1, 2025

Rounded might be best as it's more consistent with the website

image

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Feb 2, 2025

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@timdorr
Copy link
Member

timdorr commented Feb 3, 2025

Alright, thanks!

@timdorr timdorr merged commit 3b45394 into remix-run:main Feb 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants