Avoid unnecessary console error on fetcher abort due to back-to-back revalidation calls #12050
Conversation
…evalidation calls
🦋 Changeset detectedLatest commit: 68824ab The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -3018,9 +3014,10 @@ export function createRouter(init: RouterInit): Router { | |||
|
|
|||
| function abortFetcher(key: string) { | |||
| let controller = fetchControllers.get(key); | |||
| invariant(controller, `Expected fetch controller: ${key}`); | |||
There was a problem hiding this comment.
All but 2 uses of abortFetcher were already defensive against this invariant and the 2 that weren't were the bug we're fixing, so now that they all want to be defensive we can just flatten the defensive check into this method.
| @@ -2049,7 +2048,6 @@ export function createRouter(init: RouterInit): Router { | |||
| let { loaderData, errors } = processLoaderData( | |||
| state, | |||
| matches, | |||
| matchesToLoad, | |||
…revalidation calls (#12050)
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
Closes #12049