Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #11629 #11633

Merged
merged 5 commits into from
Jun 18, 2024
Merged

Fix #11629 #11633

merged 5 commits into from
Jun 18, 2024

Conversation

mspiess
Copy link
Contributor

@mspiess mspiess commented Jun 8, 2024

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 8, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1ce31c4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mspiess mspiess mentioned this pull request Jun 8, 2024
Closed
@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jun 8, 2024

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

brophdawg11
brophdawg11 reviewed Jun 14, 2024
View reviewed changes
packages/react-router/__tests__/useResolvedPath-test.tsx Outdated
Comment on lines 280 to 287
<Route
path="*"
element={
<Component desc='<Route path="/foo"><Route path="*" />' />
}
/>
<Route>
<Route
path="*"
element={
<Component desc='<Route path="/foo"><Route path="*" />' />
}
/>
</Route>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind laving the existing test as-is and added a new test for the pathless layout scenario?

Copy link
Contributor Author

@mspiess mspiess Jun 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, unless you meant adding a separate test file, like gh-issue-8127-test.tsx.

@brophdawg11 brophdawg11 self-assigned this Jun 17, 2024
@brophdawg11 brophdawg11 merged commit 4050bef into remix-run:dev Jun 18, 2024
3 checks passed
@brophdawg11 brophdawg11 mentioned this pull request Jun 18, 2024
Closed
@brophdawg11 brophdawg11 linked an issue Jun 18, 2024 that may be closed by this pull request
[Bug]: '.' not resolving to splat path even with v7_relativeSplatPath future #11629
Closed
@brophdawg11 brophdawg11 removed their assignment Jun 18, 2024
@github-actions github-actions bot mentioned this pull request Jul 1, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 1, 2024

🤖 Hello there,

We just published version 6.24.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot mentioned this pull request Jul 3, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 3, 2024

🤖 Hello there,

We just published version 6.24.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brophdawg11 brophdawg11 brophdawg11 approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: '.' not resolving to splat path even with v7_relativeSplatPath future
2 participants
@mspiess @brophdawg11