Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean build manifest output #11573

Merged
merged 2 commits into from
May 21, 2024
Merged

Conversation

markdalgleish
Copy link
Member

@markdalgleish markdalgleish commented May 21, 2024

This simplifies the build output and makes it closer to your standard Vite output by making a couple of changes:

  1. We now leave Vite manifests in their default location, e.g. build/client/.vite/manifest.json and build/server/.vite/manifest.json instead of build/.vite/client-manifest.json and build/.vite/server-manifest.json. Note that these Vite manifests are deleted unless consumers explicitly enable them via build: { manifest: true } in their Vite config. This means that the build output is now much closer to what you'd expect from a typical Vite project.

  2. We no longer have a manifest option to write a React Router build manifest to disk under build/.react-router/manifest.json. This option was originally added in Remix for Vercel so that they could enable it in their preset but then was superseded by the more powerful buildEnd hook which has access to the build manifest in memory. Since the RRv7 migration is a major release, it's a good opportunity to streamline the plugin API and remove the unnecessary manifest option.

Copy link

changeset-bot bot commented May 21, 2024

🦋 Changeset detected

Latest commit: 9360b42

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@react-router/dev Major
react-router Major
react-router-dom Major
@react-router/express Major
@react-router/node Major
@react-router/serve Major
@react-router/server-runtime Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@markdalgleish markdalgleish merged commit d4127aa into v7 May 21, 2024
7 of 8 checks passed
@markdalgleish markdalgleish deleted the markdalgleish/clean-build-manifest-output branch May 21, 2024 03:37
Copy link
Contributor

🤖 Hello there,

We just published version 6.28.2-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants