45_carbonprice: added flexibility for starting point of linear curve to diffLin2Lin #1776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to diffLin2Lin, restructured code and improved documentation of diffLin2Lin and diffExp2Lin
laurinks
force-pushed
the
carbon-price-trajectories-2
branch
from
bbb3187 to
11b5d20
Compare
laurinks
commented
Aug 21, 2024
| @@ -1,4 +1,4 @@ | |||
| title;start;copyConfigFrom;.description;CES_parameters;c_keep_iteration_gdxes;cm_calibration_string;optimization;c_testOneRegi_region;cm_solver_try_max;cm_nash_mode;cm_startIter_EDGET;subsidizeLearning;trade;cm_trade_SE_exog;cm_EnSecScen_price;cm_EnSecScen_limit;cm_Ger_Pol;c_ccsinjecratescen;c_ccsinjecrateRegi;cm_ccsinjeCost;cm_frac_NetNegEmi;cm_bioprod_regi_lim;c_tech_earlyreti_rate;cm_import_tax;cm_1stgen_phaseout;c_agricult_base_shift;cm_altFeEmiFac;cm_PriceDurSlope_elh2;cm_SEtaxRampUpParam;cm_build_H2costAddH2Inv;cm_steel_secondary_max_share_scenario;cm_CESMkup_build;cm_CESMkup_ind;cm_CESMkup_ind_data;cm_exogDem_scen;cm_wasteIncinerationCCSshare;cm_feedstockEmiUnknownFate;cm_ind_energy_limit;cm_ind_energy_limit_manual;cm_FEtax_trajectory_abs;cm_FEtax_trajectory_rel;cm_inco0Factor;cm_adj_coeff_multiplier;cm_adj_seed_multiplier;regionmapping;extramappings_historic;cm_rcp_scen;cm_iterative_target_adj;c_budgetCO2from2020;carbonprice;cm_co2_tax_2020;cm_peakBudgYr;c_taxCO2inc_after_peakBudgYr;techpol;regipol;cm_regiExoPrice;cm_emiMktTarget;cm_emiMktTarget_tolerance;cm_NucRegiPol;cm_CoalRegiPol;cm_EDGEtr_scen;cm_emiscen;cm_multigasscen;cm_POPscen;cm_GDPscen;cm_demScen;cm_startyear;path_gdx;path_gdx_ref | |||
| title;start;copyConfigFrom;.description;CES_parameters;c_keep_iteration_gdxes;cm_calibration_string;optimization;c_testOneRegi_region;cm_solver_try_max;cm_nash_mode;cm_startIter_EDGET;subsidizeLearning;trade;cm_trade_SE_exog;cm_EnSecScen_price;cm_EnSecScen_limit;cm_Ger_Pol;c_ccsinjecratescen;c_ccsinjecrateRegi;cm_ccsinjeCost;cm_frac_NetNegEmi;cm_bioprod_regi_lim;c_tech_earlyreti_rate;cm_import_tax;cm_1stgen_phaseout;c_agricult_base_shift;cm_altFeEmiFac;cm_PriceDurSlope_elh2;cm_SEtaxRampUpParam;cm_build_H2costAddH2Inv;cm_steel_secondary_max_share_scenario;cm_CESMkup_build;cm_CESMkup_ind;cm_CESMkup_ind_data;cm_exogDem_scen;cm_wasteIncinerationCCSshare;cm_feedstockEmiUnknownFate;cm_ind_energy_limit;cm_ind_energy_limit_manual;cm_FEtax_trajectory_abs;cm_FEtax_trajectory_rel;cm_inco0Factor;cm_adj_coeff_multiplier;cm_adj_seed_multiplier;regionmapping;extramappings_historic;cm_rcp_scen;cm_iterative_target_adj;c_budgetCO2from2020;carbonprice;cm_co2_tax_2020;cm_peakBudgYr;cm_taxCO2inc_after_peakBudgYr;techpol;regipol;cm_regiExoPrice;cm_emiMktTarget;cm_emiMktTarget_tolerance;cm_NucRegiPol;cm_CoalRegiPol;cm_EDGEtr_scen;cm_emiscen;cm_multigasscen;cm_POPscen;cm_GDPscen;cm_demScen;cm_startyear;path_gdx;path_gdx_ref | |||
There was a problem hiding this comment.
Only changed c_taxCO2inc_after_peakBudgYr to cm_taxCO2inc_after_peakBudgYr
laurinks
commented
Aug 21, 2024
| @@ -1,4 +1,4 @@ | |||
| title;start;slurmConfig;climate;cm_import_tax;cm_taxrc_RE;cm_magicc_calibrateTemperature2000;cm_damage_KWSE;cm_magicc_config;cm_magicc_temperatureImpulseResponse;cm_damage_DiceLike_specification;cm_damages_BurkeLike_persistenceTime;cm_damages_BurkeLike_specification;cm_damages_SccHorizon;cm_VRE_supply_assumptions;c_CES_calibration_new_structure;buildings;transport;industry;cm_wasteIncinerationCCSshare;cm_DiscRateScen;c_shBioTrans;cm_EDGEtr_scen;cm_reducCostB;cm_CES_calibration_default_prices;c_ccsinjecratescen;.CDR;cm_bioenergy_SustTax;cm_rcp_scen;cm_iterative_target_adj;subsidizeLearning;cm_LearningSpillover;c_budgetCO2from2020;carbonprice;carbonpriceRegi;cm_netZeroScen;cm_co2_tax_2020;cm_peakBudgYr;c_taxCO2inc_after_peakBudgYr;cm_CO2priceRegConvEndYr;cm_emiscen;c_regi_earlyreti_rate;c_tech_earlyreti_rate;cm_fetaxscen;cm_co2_tax_growth;cm_maxProdBiolc;c_ccscapratescen;techpol;c_techAssumptScen;cm_nucscen;cm_so2tax_scen;cm_multigasscen;cm_LU_emi_scen;cm_tradecostBio;cm_1stgen_phaseout;c_SSP_forcing_adjust;cm_APscen;water;cm_startyear;path_gdx_carbonprice;path_gdx;path_gdx_ref;path_gdx_bau;description | |||
| title;start;slurmConfig;climate;cm_import_tax;cm_taxrc_RE;cm_magicc_calibrateTemperature2000;cm_damage_KWSE;cm_magicc_config;cm_magicc_temperatureImpulseResponse;cm_damage_DiceLike_specification;cm_damages_BurkeLike_persistenceTime;cm_damages_BurkeLike_specification;cm_damages_SccHorizon;cm_VRE_supply_assumptions;c_CES_calibration_new_structure;buildings;transport;industry;cm_wasteIncinerationCCSshare;cm_DiscRateScen;c_shBioTrans;cm_EDGEtr_scen;cm_reducCostB;cm_CES_calibration_default_prices;c_ccsinjecratescen;.CDR;cm_bioenergy_SustTax;cm_rcp_scen;cm_iterative_target_adj;subsidizeLearning;cm_LearningSpillover;c_budgetCO2from2020;carbonprice;carbonpriceRegi;cm_netZeroScen;cm_co2_tax_2020;cm_peakBudgYr;cm_taxCO2inc_after_peakBudgYr;cm_CO2priceRegConvEndYr;cm_emiscen;c_regi_earlyreti_rate;c_tech_earlyreti_rate;cm_fetaxscen;cm_co2_tax_growth;cm_maxProdBiolc;c_ccscapratescen;techpol;c_techAssumptScen;cm_nucscen;cm_so2tax_scen;cm_multigasscen;cm_LU_emi_scen;cm_tradecostBio;cm_1stgen_phaseout;c_SSP_forcing_adjust;cm_APscen;water;cm_startyear;path_gdx_carbonprice;path_gdx;path_gdx_ref;path_gdx_bau;description | |||
There was a problem hiding this comment.
Only changed c_taxCO2inc_after_peakBudgYr to cm_taxCO2inc_after_peakBudgYr
|
A few additional comments for the reviewers:
|
laurinks
requested review from
orichters and
LaviniaBaumstark
and removed request for
orichters
looking forward! |
hmmm, I would say as part of teh description of teh set it would be good. In general, we know that from time to time we need to check, if our carbon price is still working as intended. So, we should think about it from time to time.... |
No, since the switch |
orichters
reviewed
Aug 22, 2024
| @@ -160,7 +160,7 @@ readCheckScenarioConfig <- function(filename, remindPath = ".", testmode = FALSE | |||
| "cm_calibration_FE" = "Deleted, only used for old hand made industry trajectories, see https://github.com/remindmodel/remind/pull/1468", | |||
| "cm_DAC_eff" = "Deleted, not used anymore, see https://github.com/remindmodel/remind/pull/1487", | |||
| "cm_peakBudgYr" = "Rename to c_peakBudgYr, see https://github.com/remindmodel/remind/pull/1488", | |||
| "cm_taxCO2inc_after_peakBudgYr" = "Rename to c_taxCO2inc_after_peakBudgYr, see https://github.com/remindmodel/remind/pull/1488", | |||
| "c_taxCO2inc_after_peakBudgYr" = "Rename to cm_taxCO2inc_after_peakBudgYr, see https://github.com/remindmodel/remind/pull/1776", | |||
There was a problem hiding this comment.
At some point, I wonder whether it would be easier to just accept both cm_taxCO2inc_after_peakBudgYr and c_taxCO2inc_after_peakBudgYr as a switch :D
| @@ -8,6 +8,18 @@ | |||
|
|
|||
| *#' @description: This realization implements linearly increasing carbon price - either until 2100 or until peak year (constant or linear thereafter). Optional carbon price differentiation and quadratic phase-in can be activated via switch cm_co2_tax_spread. | |||
|
|
|||
| ***-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | |||
There was a problem hiding this comment.
thanks for adding precise documentation
Yes, but I did not see any changes that might affect the reporting. Did you have a specific aspect in mind? |
orichters
approved these changes
Aug 22, 2024
no, thanks |
LaviniaBaumstark
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
cm_co2_tax_histandcm_year_co2_tax_histto enable flexible start point of linear CO2 price trajectory indiffLin2Linof45_carbonprice. By default,cm_year_co2_tax_histis the last time period beforecm_startyear(e.g. 2020 if start year is 2025) andcm_co2_tax_histis level of CO2 tax (defined as maximum ofpm_taxCO2eqover all regions) frompath_gdx_refincm_year_co2_tax_hist(e.g. 25$ in 2020).diffLin2LinanddiffExp2LindiffLin2LinanddiffExp2Linwithcm_iterative_target_adj = 0in order to easily create exogenous CO2 price trajectories using the switchescm_co2_tax_startyearandcm_peakBudgYrType of change
Checklist:
remind2where it was neededforbiddenColumnNamesin readCheckScenarioConfig.R in case the PR leads to deprecated switchesFAIL 0in the output ofmake test)CHANGELOG.mdhas been updated correctlyFurther information:
/p/tmp/laurinko/hpc/remind/output(all folders created on 08/08/2024). Information on convergence:The execution errors for SSP2-PkBudg500 runs with start year 2030 are a consequence of the shifted start year (compared to 2025 in default runs) together with a very tight budget. The repeated non-convergence for SSP2-PkBudg650-Hotelling runs (i.e. uniform exponentially increasing CO2 price trajectory until peak year, then constant) is due to failed markets and failed tax convergence. However, the successful convergence of runs with other budget (500 or 1050) but otherwise identical settings indicates that this is not an general problem of the
diffExp2Linrealizationcm_co2_tax_histandcm_year_co2_tax_histhave values25 $ / t CO2and2020which agrees with the values for the starting point of the linear curve that had been hard-coded so far. For completeness, here are the CO2 price trajectories:diffLin2Linrealization, i.e. linear curve going through (2020,25$), with an alternative setting, where the linear curve goes through (2024, 25$).diffLin2Linrealization, i.e. linear curve going through (period before start year = 2025, maximal CO2 price among all regions in 2025 in NPi run = 25$), with an alternative setting, where the linear curve goes through (2025, 100$).