Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing edget scenario, reset sets to H12 #1754

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

orichters
Copy link
Contributor

@orichters orichters commented Jul 19, 2024

Purpose of this PR

  • avoid that edgeTransport 2.0 release #1749 leads to compilation failure
  • Removing the scenario is not possible as long as it is in the input data
  • add some --partition=priority to --qos=priority calls because the cluster does stupid things and the tests failed without it

Type of change

  • Bug fix

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted the reporting in remind2 where it was needed
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • All automated model tests pass (FAIL 0 in the output of make test): [ FAIL 0 | WARN 0 | SKIP 6 | PASS 83 ]
  • The changelog CHANGELOG.md has been updated correctly

@orichters orichters marked this pull request as ready for review July 19, 2024 07:22
@orichters orichters requested a review from jmuessel July 19, 2024 07:27
LAM_regi .(LAM)
OAS_regi .(OAS)
SSA_regi .(SSA)
EUR_regi .(ENC,EWN,ECS,ESC,ECE,FRA,DEU,UKI,ESW)
NEU_regi .(NES,NEN)
EUR_regi .(EUR)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this necessary? Same question for the other changes regarding regions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, these settings are automatically adapted by the start scripts. Normally, in this repository, they are saved in the REMIND H12 mode, but Johanna apparently ran some REMIND EU-21 tests at the end and committed the adjusted values. It is no problem, but I still prefer to undo it.

@orichters orichters merged commit 6f462a7 into remindmodel:develop Jul 19, 2024
2 checks passed
@orichters orichters deleted the maindevelop branch August 6, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants