Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSP-804- Add a maxmemory_policy variable to the google/redis module #65

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

Yasmine-97
Copy link
Contributor

@Yasmine-97 Yasmine-97 commented Jan 31, 2025

@Yasmine-97 Yasmine-97 requested a review from a team as a code owner January 31, 2025 14:33
@remerge-hal
Copy link

This comment ensures that the correct Slack channel is notified after the team/project label DSP has been added to this pull request.

See this comment for details.

Copy link

@madyankin madyankin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn’t find a PR to override the maxmemory_policy with noeviction. Did you create it or is it still to be created?

@Yasmine-97
Copy link
Contributor Author

@madyankin I can only open the api PR to override it once this one is merged is released. This is because we'd need to reference this repo by release number. example here.

@hollow can you take a look here 🙏🏼

@hollow
Copy link
Member

hollow commented Feb 4, 2025

@madyankin I can only open the api PR to override it once this one is merged is released. This is because we'd need to reference this repo by release number. example here.

You can also use a branch name as ref= for testing :)

@Yasmine-97 Yasmine-97 merged commit a5e3bad into main Feb 4, 2025
3 checks passed
@Yasmine-97 Yasmine-97 deleted the DSP-804 branch February 4, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

5 participants