DSP-774-fix-error-using-reserved-name-for-var #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The variable name "version" is reserved due to its special meaning inside module blocks.
|
This comment ensures that the correct Slack channel is notified after the team/project label See this comment for details. |
Yasmine-97
changed the title
hollow
approved these changes
Jan 20, 2025
Yasmine-97
changed the title
|
@hollow is it possible to later add a validation step in CI to prevent this happening again? |
hollow
approved these changes
Jan 20, 2025
What kind of validation do you have in mind? You can test these changes before merging by using the branch name as |
|
I mean in this terraform-modules repo not where it's used, the CI pipeline could have caught the error when the resource was first defined. Not sure if I am missing something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://remerge.atlassian.net/browse/DSP-774
The variable name "version" is reserved due to its special meaning inside module blocks.