Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with @monaco-editor/react. Is web worker necessary? #119

Closed
andrewfschorr opened this issue Sep 28, 2021 · 0 comments · Fixed by #133
Closed

Incompatible with @monaco-editor/react. Is web worker necessary? #119

andrewfschorr opened this issue Sep 28, 2021 · 0 comments · Fixed by #133

Comments

@andrewfschorr
Copy link

From the readme:

Also make sure to register the web worker.

Going through the previous issues, and looking at all the examples (example: #92 (comment)) it seems that instantiating the Web Worker is necessary. I'm curious why this is needed especially since the current playground on the official site has no mentions of a worker: https://microsoft.github.io/monaco-editor/playground.html#extending-language-services-configure-json-defaults. I'd be happy to submit a PR to update the readme, but I'm a bit curious what the worker provides.

This all stems from trying to implement monaco-yaml in a create-react-app application without ejecting. In a best case scenario I'd like to be able to use this with https://www.npmjs.com/package/@monaco-editor/react, however it seems that it's incompatible in it's current state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant