Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SSE to event forms #1

Merged
merged 2 commits into from
Aug 27, 2021
Merged

Add SSE to event forms #1

merged 2 commits into from
Aug 27, 2021

Conversation

benfrancis
Copy link

@benfrancis benfrancis commented Aug 19, 2021

This is an update to the forms of Thing Descriptions to reflect the Server-Sent Events implementation in WebThingsIO#2863

Notes:

  1. This adds a subprotocol member to event forms with a value of 'sse'
  2. A top level form for properties or events is only added if the thing has properties or events respectively
  3. I've removed the writeallproperties op from properties at the same time since I don't think it's actually supported in the API
  4. I don't add a subprotocol member to proxied forms, I'm not sure whether or not this is the best thing to do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants