Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for token authentification problem #222

Closed
wants to merge 1 commit into from

Conversation

mvalik
Copy link
Contributor

@mvalik mvalik commented Jul 19, 2024

This workaround uses a direct request to introspect a token without any libraries.

@mvalik mvalik requested a review from hluk July 19, 2024 00:02
Copy link
Member

@hluk hluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not sure what is the problem.

Can we fix this in flask-oidc (or authlib)? Are these unable to load the token or use the OpenID endpoint properly?

waiverdb/auth.py Outdated Show resolved Hide resolved
@mvalik mvalik force-pushed the vm_branch_token_introspection_wa branch from dbe6230 to b2c5837 Compare July 19, 2024 08:25
@AdamWill
Copy link
Contributor

this was @mvalik 's stopgap solution while I tried to figure out why having authlib do the introspection for us wasn't working. if we can get lepture/authlib#662 deployed this shouldn't be necessary, I don't think.

@mvalik mvalik force-pushed the vm_branch_token_introspection_wa branch from b2c5837 to 2985f00 Compare July 19, 2024 15:30
@AdamWill
Copy link
Contributor

We should only merge either this or #223 , personally I think #223 is somewhat cleaner (and it's been tested, I'm not sure whether we ever actually tested if this one would work).

@mvalik
Copy link
Contributor Author

mvalik commented Aug 1, 2024

Closing this, since #223 has been merged.

@mvalik mvalik closed this Aug 1, 2024
@mvalik mvalik deleted the vm_branch_token_introspection_wa branch August 1, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants