Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump IIB's depdendencies #748

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Bump IIB's depdendencies #748

merged 3 commits into from
Jan 9, 2025

Conversation

JAVGan
Copy link
Contributor

@JAVGan JAVGan commented Jan 8, 2025

Changes:

  • f40b258 Bump IIB's dependencies to the latest versions (but operator-manifests which is breaking the implemented tests)
  • 14c8027 Fix new mypy error on IIB Web models
  • e8d0c72 Adds setuptools to the requirements-test* files so the GH CI can
    properly run the unit-tests

@JAVGan JAVGan force-pushed the bump branch 3 times, most recently from d345301 to 2990b1f Compare January 8, 2025 18:27
@JAVGan
Copy link
Contributor Author

JAVGan commented Jan 8, 2025

@release-engineering/exd-guild-hello-operator PTAL

Below my comments:

  1. The first commit reflects this PR intent, which is to bump the internal dependencies. However, when bumping operator-manifest from 0.0.5 to 2.0.1 it breaks the following tests:
FAILED tests/test_workers/test_tasks/test_build_regenerate_bundle.py::test_adjust_operator_bundle_unordered - operator_manifest.helpers.ValidationException: .spec: validating 'required' has failed ('install' is a required property)
FAILED tests/test_workers/test_tasks/test_build_regenerate_bundle.py::test_adjust_operator_bundle_ordered - operator_manifest.helpers.ValidationException: .spec: validating 'required' has failed ('install' is a required property)
FAILED tests/test_workers/test_tasks/test_build_regenerate_bundle.py::test_adjust_operator_bundle_already_pinned_by_iib - operator_manifest.helpers.ValidationException: .spec: validating 'required' has failed ('install' is a required property)
FAILED tests/test_workers/test_tasks/test_build_regenerate_bundle.py::test_adjust_operator_bundle_perform_bundle_replacements - operator_manifest.helpers.ValidationException: .spec: validating 'required' has failed ('install' is a required property)
FAILED tests/test_workers/test_tasks/test_build_regenerate_bundle.py::test_adjust_csv_annotations - operator_manifest.helpers.ValidationException: at top level: validating 'required' has failed ('metadata' is a required property)
FAILED tests/test_workers/test_tasks/test_build_regenerate_bundle.py::test_replace_image_name_from_labels[namespace/reponame] - operator_manifest.helpers.ValidationException: .spec: validating 'required' has failed ('install' is a required property)
FAILED tests/test_workers/test_tasks/test_build_regenerate_bundle.py::test_replace_image_name_from_labels[reponame-only] - operator_manifest.helpers.ValidationException: .spec: validating 'required' has failed ('install' is a required property)
FAILED tests/test_workers/test_tasks/test_build_regenerate_bundle.py::test_replace_image_name_from_labels[foo/bar/some] - operator_manifest.helpers.ValidationException: .spec: validating 'required' has failed ('install' is a required property)
FAILED tests/test_workers/test_tasks/test_build_regenerate_bundle.py::test_replace_image_name_from_labels_invalid_labels - operator_manifest.helpers.ValidationException: .spec: validating 'required' has failed ('install' is a required property)
FAILED tests/test_workers/test_tasks/test_build_regenerate_bundle.py::test_apply_repo_enclosure[/image-company-pending-operator----image] - operator_manifest.helpers.ValidationException: .spec: validating 'required' has failed ('install' is a required property)
FAILED tests/test_workers/test_tasks/test_build_regenerate_bundle.py::test_apply_repo_enclosure[/image/foo/bar-operator-image----foo----bar] - operator_manifest.helpers.ValidationException: .spec: validating 'required' has failed ('install' is a required property)
FAILED tests/test_workers/test_tasks/test_build_regenerate_bundle.py::test_apply_repo_enclosure[/image-operator-image] - operator_manifest.helpers.ValidationException: .spec: validating 'required' has failed ('install' is a required property)
FAILED tests/test_workers/test_tasks/test_build_regenerate_bundle.py::test_apply_repo_enclosure[-image-company-managed-operator-image] - operator_manifest.helpers.ValidationException: .spec: validating 'required' has failed ('install' is a required property)
FAILED tests/test_workers/test_tasks/test_build_regenerate_bundle.py::test_adjust_operator_bundle_duplicate_customizations_ordered - operator_manifest.helpers.ValidationException: .spec: validating 'required' has failed ('install' is a required property)
FAILED tests/test_workers/test_tasks/test_build_regenerate_bundle.py::test_adjust_operator_bundle_ordered_recursive_related_bundles - operator_manifest.helpers.ValidationException: .spec: validating 'required' has failed ('install' is a required property)

  1. Commits 14c8027..e8d0c72 are just meant to fix the CI which was somehow broken:

    a. I've patched some code to fix the new issue caught by the most recent version of mypy: error: Enum members must be left unannotated [misc]

    b. I had to include the setuptools in the requirements-test* using the --allow-unsafe flag, as without it the unit-tests were failing with .ModuleNotFoundError: No module named 'pkg_resources'. I've tried not doing it by installing the package directly in the .github/workflows/run_tox.yml#L29 but it didn't work 😞

JAVGan added 3 commits January 8, 2025 16:29
Bump IIB's dependencies to the latest versions but `operator-manifests`
which has been temporarily pinned to `v0.0.5` to avoid breaking existing
tests
This fixes the new `mypy` issue:

```
error: Enum members must be left unannotated  [misc]
```
Adds setuptools to the `requiremenets-test*` files so the GH CI can
properly run the unit-tests
Copy link
Contributor

@xDaile xDaile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not like the addition of the --alow-unsafe option, but I did not find any alternative as well.

@JAVGan JAVGan merged commit 2b40fe1 into master Jan 9, 2025
2 checks passed
@JAVGan JAVGan deleted the bump branch January 9, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants