use registry token for inspecting image from private repo [CLOUDDST-10044] #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chandwanitulsi
commented
Oct 25, 2021
| @@ -86,7 +86,7 @@ def handle_create_empty_index_request( | |||
|
|
|||
| _update_index_image_build_state(request_id, prebuild_info) | |||
| with tempfile.TemporaryDirectory(prefix='iib-') as temp_dir: | |||
| if is_image_dc(from_index): | |||
| if is_image_dc(from_index_resolved): | |||
There was a problem hiding this comment.
For create-empty-index and merge-index endpoints, we don't have any tokens right? Do we have any use case where these endpoints are used with a from_index from a private registry?
There was a problem hiding this comment.
Agree for create-empty-index. See my comment on merge-index.
chandwanitulsi
requested review from
yashvardhannanavati,
lipoja,
querti and
lcarva
lcarva
reviewed
Oct 25, 2021
| @@ -194,7 +194,7 @@ def handle_merge_request( | |||
| target_index_resolved = prebuild_info['target_index_resolved'] | |||
|
|
|||
| with tempfile.TemporaryDirectory(prefix='iib-') as temp_dir: | |||
| if is_image_dc(source_from_index): | |||
| if is_image_dc(source_from_index_resolved): | |||
There was a problem hiding this comment.
There is overwrite_target_index_token but that doesn't seem to be used when inspecting the source index image. I think your reasoning to not set the registry secret here is correct. There would be additional changes to support that use case.
lcarva
approved these changes
Oct 25, 2021
yashvardhannanavati
approved these changes
Oct 25, 2021
chandwanitulsi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refers to CLOUDDST-10044