Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the latest skpkg .pre-commit-config.yml #1243

Merged
merged 3 commits into from
Jan 31, 2025
Merged

Conversation

ycexiao
Copy link
Contributor

@ycexiao ycexiao commented Jan 30, 2025

close #1225

@ycexiao ycexiao marked this pull request as ready for review January 30, 2025 20:32
@ycexiao
Copy link
Contributor Author

ycexiao commented Jan 30, 2025

@sbillinge It's ready for review, thank you!

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.64%. Comparing base (d0a4042) to head (0441753).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1243   +/-   ##
=======================================
  Coverage   79.64%   79.64%           
=======================================
  Files          17       17           
  Lines        1366     1366           
=======================================
  Hits         1088     1088           
  Misses        278      278           
Files with missing lines Coverage Δ
tests/conftest.py 60.37% <ø> (ø)
tests/test_builders.py 84.28% <ø> (ø)
tests/test_validate.py 100.00% <ø> (ø)
tests/test_version.py 100.00% <ø> (ø)

@sbillinge sbillinge merged commit 4c244d6 into regro:main Jan 31, 2025
5 checks passed
@sbillinge
Copy link
Contributor

Thanks @ethan-yuchen nicely done there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants