Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.12 build #85

Merged
merged 3 commits into from
Dec 31, 2023
Merged

Add Python 3.12 build #85

merged 3 commits into from
Dec 31, 2023

Conversation

offa
Copy link
Contributor

@offa offa commented Oct 16, 2023

First steps to support to support Python 3.12.

There's a build failure on Ubuntu though:

   Traceback (most recent call last):
    File "/home/runner/work/cmake-language-server/cmake-language-server/.tox/py312/bin/mypy", line 5, in <module>
      from mypy.__main__ import console_entry
    File "/home/runner/work/cmake-language-server/cmake-language-server/.tox/py312/lib/python3.12/site-packages/mypy/__main__.py", line 9, in <module>
      from mypy.main import main, process_options
    File "/home/runner/work/cmake-language-server/cmake-language-server/.tox/py312/lib/python3.12/site-packages/mypy/main.py", line 12, in <module>
      from typing_extensions import Final
    File "/home/runner/work/cmake-language-server/cmake-language-server/.tox/py312/lib/python3.12/site-packages/typing_extensions.py", line 1167, in <module>
      class TypeVar(typing.TypeVar, _DefaultMixin, _root=True):
  TypeError: type 'typing.TypeVar' is not an acceptable base type

@offa offa requested a review from regen100 as a code owner October 16, 2023 19:23
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8cc05ad) 92.19% compared to head (8c6b18a) 92.19%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #85   +/-   ##
=======================================
  Coverage   92.19%   92.19%           
=======================================
  Files           3        3           
  Lines         333      333           
=======================================
  Hits          307      307           
  Misses         26       26           
Flag Coverage Δ
unittests 92.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@regen100
Copy link
Owner

The tests passed in my own environment. I will do some more debugging.

@tan-wei tan-wei mentioned this pull request Dec 28, 2023
@tan-wei
Copy link

tan-wei commented Dec 28, 2023

Any progress then?

@tan-wei
Copy link

tan-wei commented Dec 28, 2023

The failure seems not related to the test. Re-run CI may become pass.

@offa
Copy link
Contributor Author

offa commented Dec 28, 2023

I still get the same error on replay unfortunately. But it may be fixed by typing extensions >= 4.7.0 (4.4.0 is used at the moment).

@offa
Copy link
Contributor Author

offa commented Dec 28, 2023

This seems to fix the Python 3.12 build 🎉. Python 3.7 is broken now though:

Python 3.8 or above is required to install PDM.

@offa
Copy link
Contributor Author

offa commented Dec 28, 2023

Given Python 3.7 is EOL, I suggest removing it.

This needs an update of the projects CI settings too (3.7 is still required, but 3.12 not).

@tan-wei
Copy link

tan-wei commented Dec 29, 2023

Good news!

Copy link
Owner

@regen100 regen100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR. Dropping 3.7 support is reasonable.

@regen100 regen100 merged commit 9529df5 into regen100:master Dec 31, 2023
11 checks passed
@Sologala
Copy link

Sologala commented Jan 1, 2024

Hi, @regen100 When will this commit be released?
I encountered this version-related issue too when I tried to start the CMake Language Server using Mason in Neovim on the Windows platform.
Mason automaticlly fetch 0.1.8 cmake-language-server. As you can get some mason default registration info of lsp-servers here

@regen100
Copy link
Owner

regen100 commented Jan 1, 2024

0.1.9 released!

@offa offa deleted the ci branch January 2, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants