-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python 3.12 build #85
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #85 +/- ##
=======================================
Coverage 92.19% 92.19%
=======================================
Files 3 3
Lines 333 333
=======================================
Hits 307 307
Misses 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The tests passed in my own environment. I will do some more debugging. |
Any progress then? |
The failure seems not related to the test. Re-run CI may become pass. |
I still get the same error on replay unfortunately. But it may be fixed by typing extensions >= 4.7.0 (4.4.0 is used at the moment). |
This seems to fix the Python 3.12 build 🎉. Python 3.7 is broken now though:
|
Given Python 3.7 is EOL, I suggest removing it. This needs an update of the projects CI settings too (3.7 is still required, but 3.12 not). |
Good news! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR. Dropping 3.7 support is reasonable.
Hi, @regen100 When will this commit be released?
|
0.1.9 released! |
First steps to support to support Python 3.12.
There's a build failure on Ubuntu though: