Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support slack webhooks #91

Merged
merged 15 commits into from
Jul 28, 2020
Merged

Support slack webhooks #91

merged 15 commits into from
Jul 28, 2020

Conversation

rjulian
Copy link
Contributor

@rjulian rjulian commented Jul 28, 2020

No description provided.

@rjulian rjulian requested review from mcbanderson and rot26 July 28, 2020 22:04
@rot26
Copy link
Contributor

rot26 commented Jul 28, 2020

I was under the impression that reflex would handle events up to SNS. everything after the SNS topic is a subscription handler. I think it would be best to keep this separate from our lambda code

rot26
rot26 approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@rot26 rot26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with #92 so we don't get into the business of adding a bunch of sns integrations into the engine code

@rjulian rjulian merged commit 72aca87 into master Jul 28, 2020
@mcbanderson mcbanderson deleted the support_slack_webhooks branch August 16, 2020 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rot26 rot26 rot26 approved these changes

@mcbanderson mcbanderson Awaiting requested review from mcbanderson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rjulian @rot26