Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't check types that have defaults after what is provided #4889

Merged

Conversation

adhami3310
Copy link
Member

No description provided.

Copy link

codspeed-hq bot commented Mar 1, 2025

CodSpeed Performance Report

Merging #4889 will degrade performances by 3.44%

Comparing don't-check-types-that--have-defaults-after-what-is-provided (7ed86b1) with main (33714aa)

Summary

❌ 1 regressions
✅ 11 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_compile_stateful[_simple_page] 267.1 µs 276.7 µs -3.44%

@adhami3310 adhami3310 merged commit 15a55ae into main Mar 1, 2025
42 of 43 checks passed
@adhami3310 adhami3310 deleted the don't-check-types-that--have-defaults-after-what-is-provided branch March 1, 2025 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants