Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in dataeditor prop #4281

Merged
merged 2 commits into from
Oct 31, 2024
Merged

fix typo in dataeditor prop #4281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c76feee
fix typo in dataeditor prop
adhami3310 Oct 31, 2024
7298c67
move other ones as well
adhami3310 Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions reflex/components/datadisplay/dataeditor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ class DataEditor(NoSSRComponent):
get_cell_content: Var[str]

# Allow selection for copying.
get_cell_for_selection: Var[bool]
get_cells_for_selection: Var[bool]

# Allow paste.
on_paste: Var[bool]
Expand Down Expand Up @@ -424,7 +424,7 @@ def create(cls, *children, **props) -> Component:
props["theme"] = DataEditorTheme(**theme)

# Allow by default to select a region of cells in the grid.
props.setdefault("get_cell_for_selection", True)
props.setdefault("get_cells_for_selection", True)

# Disable on_paste by default if not provided.
props.setdefault("on_paste", False)
Expand Down
4 changes: 2 additions & 2 deletions reflex/components/datadisplay/dataeditor.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ class DataEditor(NoSSRComponent):
] = None,
data: Optional[Union[List[List[Any]], Var[List[List[Any]]]]] = None,
get_cell_content: Optional[Union[Var[str], str]] = None,
get_cell_for_selection: Optional[Union[Var[bool], bool]] = None,
get_cells_for_selection: Optional[Union[Var[bool], bool]] = None,
on_paste: Optional[Union[Var[bool], bool]] = None,
draw_focus_ring: Optional[Union[Var[bool], bool]] = None,
fixed_shadow_x: Optional[Union[Var[bool], bool]] = None,
Expand Down Expand Up @@ -228,7 +228,7 @@ class DataEditor(NoSSRComponent):
columns: Headers of the columns for the data grid.
data: The data.
get_cell_content: The name of the callback used to find the data to display.
get_cell_for_selection: Allow selection for copying.
get_cells_for_selection: Allow selection for copying.
on_paste: Allow paste.
draw_focus_ring: Controls the drawing of the focus ring.
fixed_shadow_x: Enables or disables the overlay shadow when scrolling horizontally.
Expand Down
Loading