[REF-2588]Clear color mode local storage for dev mode #3548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElijahAhianyo
changed the title
masenf
reviewed
Jun 28, 2024
| defaultColorMode, | ||
| isDevMode, | ||
| } from "/utils/context.js"; | ||
| import { lastCompiledTimeStamp } from "/utils/context.js"; |
There was a problem hiding this comment.
i think this can go in the import list in the line above
masenf
approved these changes
Jun 28, 2024
cutoffthetop
referenced
this pull request
in robert-koch-institut/mex-editor
Jul 16, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [reflex](https://reflex.dev) ([source](https://github.com/reflex-dev/reflex)) | project.dependencies | patch | `==0.5.5` -> `==0.5.6` | --- ### Release Notes <details> <summary>reflex-dev/reflex (reflex)</summary> ### [`v0.5.6`](https://github.com/reflex-dev/reflex/releases/tag/v0.5.6) [Compare Source](https://github.com/reflex-dev/reflex/compare/v0.5.5...v0.5.6) #### New Features ##### `rx.clipboard` Handle global and component-scoped `on_paste` with multi-type data - Add Clipboard component for handling global on_paste event by [@​masenf](https://github.com/masenf) in [https://github.com/reflex-dev/reflex/pull/3513](https://github.com/reflex-dev/reflex/pull/3513) ##### `rx.breakpoints` - Set breakpoints by name - introduce customizable breakpoints by [@​adhami3310](https://github.com/adhami3310) in [https://github.com/reflex-dev/reflex/pull/3568](https://github.com/reflex-dev/reflex/pull/3568) - add responsive props to radix components by [@​adhami3310](https://github.com/adhami3310) in [https://github.com/reflex-dev/reflex/pull/3583](https://github.com/reflex-dev/reflex/pull/3583) ##### Computed Backend Vars - add computed backend vars by [@​benedikt-bartscher](https://github.com/benedikt-bartscher) in [https://github.com/reflex-dev/reflex/pull/3573](https://github.com/reflex-dev/reflex/pull/3573) - improve backend var determination by [@​benedikt-bartscher](https://github.com/benedikt-bartscher) in [https://github.com/reflex-dev/reflex/pull/3587](https://github.com/reflex-dev/reflex/pull/3587) #### Improvements - \[REF-3056]Config knob for redis StateManager expiration times by [@​ElijahAhianyo](https://github.com/ElijahAhianyo) in [https://github.com/reflex-dev/reflex/pull/3523](https://github.com/reflex-dev/reflex/pull/3523) - \[Perf] Ensure rx.match gets memoized to avoid excessive re-rendering by [@​masenf](https://github.com/masenf) in [https://github.com/reflex-dev/reflex/pull/3552](https://github.com/reflex-dev/reflex/pull/3552) - bare sqlalchemy session + tests by [@​benedikt-bartscher](https://github.com/benedikt-bartscher) in [https://github.com/reflex-dev/reflex/pull/3522](https://github.com/reflex-dev/reflex/pull/3522) - Remove chakra from codeblock by [@​abulvenz](https://github.com/abulvenz) in [https://github.com/reflex-dev/reflex/pull/3570](https://github.com/reflex-dev/reflex/pull/3570) - add compilation timestamp in log by [@​Lendemor](https://github.com/Lendemor) in [https://github.com/reflex-dev/reflex/pull/3563](https://github.com/reflex-dev/reflex/pull/3563) - \[REF-3148] add props for tabs by [@​Lendemor](https://github.com/Lendemor) in [https://github.com/reflex-dev/reflex/pull/3560](https://github.com/reflex-dev/reflex/pull/3560) - show the value causing problem in deprecation warning by [@​Lendemor](https://github.com/Lendemor) in [https://github.com/reflex-dev/reflex/pull/3558](https://github.com/reflex-dev/reflex/pull/3558) - Better support for Github Codespaces - Add a link to backend in connection error by [@​masenf](https://github.com/masenf) in [https://github.com/reflex-dev/reflex/pull/3044](https://github.com/reflex-dev/reflex/pull/3044) - Better hot reload times on Windows with python 3.12 and uvicorn > 0.20 - \[REF-3164] Hack to fix Windows hot reload + Uvicorn upgrade by [@​masenf](https://github.com/masenf) in [https://github.com/reflex-dev/reflex/pull/3584](https://github.com/reflex-dev/reflex/pull/3584) - `rx.theme` appearance is reset in dev mode - \[REF-2588]Clear color mode local storage for dev mode by [@​ElijahAhianyo](https://github.com/ElijahAhianyo) in [https://github.com/reflex-dev/reflex/pull/3548](https://github.com/reflex-dev/reflex/pull/3548) #### Bug Fixes - Fix radix radio cards component by [@​emmakodes](https://github.com/emmakodes) in [https://github.com/reflex-dev/reflex/pull/3545](https://github.com/reflex-dev/reflex/pull/3545) - fix small typing issue by [@​Lendemor](https://github.com/Lendemor) in [https://github.com/reflex-dev/reflex/pull/3562](https://github.com/reflex-dev/reflex/pull/3562) - \[REF-3185]\[REF-3180]Dont escape backticks in JS string interpolation by [@​ElijahAhianyo](https://github.com/ElijahAhianyo) in [https://github.com/reflex-dev/reflex/pull/3566](https://github.com/reflex-dev/reflex/pull/3566) - classvars should not be backend vars by [@​benedikt-bartscher](https://github.com/benedikt-bartscher) in [https://github.com/reflex-dev/reflex/pull/3578](https://github.com/reflex-dev/reflex/pull/3578) - ComponentState and State mixins now work with backend vars - copy backend vars from mixins by [@​benedikt-bartscher](https://github.com/benedikt-bartscher) in [https://github.com/reflex-dev/reflex/pull/3580](https://github.com/reflex-dev/reflex/pull/3580) - fix var dependency over properties by [@​benedikt-bartscher](https://github.com/benedikt-bartscher) in [https://github.com/reflex-dev/reflex/pull/3588](https://github.com/reflex-dev/reflex/pull/3588) - \[REF-3157] Avoid SQLModel metaclass conflict ([#​3610](https://github.com/reflex-dev/reflex/issues/3610)) - \[REF-3220] Fix rx.cancel_upload EventSpec ([#​3608](https://github.com/reflex-dev/reflex/issues/3608)) - do not get_config in global scope ([#​3597](https://github.com/reflex-dev/reflex/issues/3597)) #### Other Changes - Validate ComputedVar dependencies, add tests by [@​benedikt-bartscher](https://github.com/benedikt-bartscher) in [https://github.com/reflex-dev/reflex/pull/3527](https://github.com/reflex-dev/reflex/pull/3527) - do not validate non-cached var deps by [@​benedikt-bartscher](https://github.com/benedikt-bartscher) in [https://github.com/reflex-dev/reflex/pull/3576](https://github.com/reflex-dev/reflex/pull/3576) - Radio group fix deprecation warning for creating vars with strings by [@​ElijahAhianyo](https://github.com/ElijahAhianyo) in [https://github.com/reflex-dev/reflex/pull/3567](https://github.com/reflex-dev/reflex/pull/3567) - update dependencies pinning by [@​Lendemor](https://github.com/Lendemor) in [https://github.com/reflex-dev/reflex/pull/3556](https://github.com/reflex-dev/reflex/pull/3556) - fix formatting by [@​benedikt-bartscher](https://github.com/benedikt-bartscher) in [https://github.com/reflex-dev/reflex/pull/3574](https://github.com/reflex-dev/reflex/pull/3574) - order type annotations in pyi_generator by [@​benedikt-bartscher](https://github.com/benedikt-bartscher) in [https://github.com/reflex-dev/reflex/pull/3585](https://github.com/reflex-dev/reflex/pull/3585) - Deprecate cached var by [@​benedikt-bartscher](https://github.com/benedikt-bartscher) in [https://github.com/reflex-dev/reflex/pull/3582](https://github.com/reflex-dev/reflex/pull/3582) - Change Strategy Prop to Literal by [@​Alek99](https://github.com/Alek99) in [https://github.com/reflex-dev/reflex/pull/3575](https://github.com/reflex-dev/reflex/pull/3575) - pyi_generator cleanup: ruff, remove fully qualified reflex. names by [@​masenf](https://github.com/masenf) in [https://github.com/reflex-dev/reflex/pull/3591](https://github.com/reflex-dev/reflex/pull/3591) - cleanup unused check by [@​benedikt-bartscher](https://github.com/benedikt-bartscher) in [https://github.com/reflex-dev/reflex/pull/3590](https://github.com/reflex-dev/reflex/pull/3590) - split lifespan and middleware logic in separate mixin files by [@​Lendemor](https://github.com/Lendemor) in [https://github.com/reflex-dev/reflex/pull/3557](https://github.com/reflex-dev/reflex/pull/3557) - Update links to /docs/library/dynamic-rendering/foreach/ ([#​3609](https://github.com/reflex-dev/reflex/issues/3609)) #### New Contributors ##### Welcome Khaleel to the Core Team - [@​adhami3310](https://github.com/adhami3310) made their first contribution in [https://github.com/reflex-dev/reflex/pull/3568](https://github.com/reflex-dev/reflex/pull/3568) **Full Changelog**: reflex-dev/reflex@v0.5.5...v0.5.6 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzEuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQzMS43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes an app's
appearancevalue(rx.App(theme=rx.theme(appearance="dark"))) does not persist correctly in the local storage(aschakra-ui-color-mode). Eg, if you manipulate the local storage value and restart the app, the app's theme/color-mode is not respected. This is typically annoying in dev mode.We want to clear this local storage key(
chakra-ui-color-mode) when the app is started or when the app is hot reloaded, in this case, the app's theme/appearance/color-mode will be persisted and respected.We do this by keeping a timestamp of the last time the app was compiled and saving this value in the local storage. For cases where the local storage value of the timestamp is any other than what is generated in
context.jsat the time of compilation, we clear the local storage key(ofchakra-ui-color-mode).closes #2047 #3548