Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #304: Relax type requirement on pc.cond #323

Merged
merged 3 commits into from
Jan 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 2 additions & 17 deletions pynecone/components/layout/cond.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
"""Create a list of components from an iterable."""
from __future__ import annotations

from typing import Optional

import pydantic
from typing import Any, Optional

from pynecone.components.component import Component
from pynecone.components.layout.fragment import Fragment
Expand All @@ -15,7 +13,7 @@ class Cond(Component):
"""Render one of two components based on a condition."""

# The cond to determine which component to render.
cond: Var[bool]
cond: Var[Any]

# The component to render if the cond is true.
comp1: Component
Expand All @@ -26,19 +24,6 @@ class Cond(Component):
# Whether the cond is within another cond.
is_nested: bool = False

@pydantic.validator("cond")
def validate_cond(cls, cond: Var) -> Var:
"""Validate that the cond is a boolean.

Args:
cond: The cond to validate.

Returns:
The validated cond.
"""
assert issubclass(cond.type_, bool), "The var must be a boolean."
return cond

@classmethod
def create(
cls, cond: Var, comp1: Component, comp2: Optional[Component] = None
Expand Down
4 changes: 3 additions & 1 deletion pynecone/components/tags/cond_tag.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
"""Tag to conditionally render components."""

from typing import Any

from pynecone import utils
from pynecone.components.tags.tag import Tag
from pynecone.var import Var
Expand All @@ -9,7 +11,7 @@ class CondTag(Tag):
"""A conditional tag."""

# The condition to determine which component to render.
cond: Var[bool]
cond: Var[Any]

# The code to render if the condition is true.
true_value: str
Expand Down
41 changes: 41 additions & 0 deletions tests/components/layout/test_cond.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
import pytest

import pynecone as pc
from pynecone.components.layout.cond import Cond
from pynecone.components.typography.text import Text


@pytest.fixture
def cond_state(request):
class CondState(pc.State):
value: request.param["value_type"] = request.param["value"]

return CondState


@pytest.mark.parametrize(
"cond_state",
[
pytest.param({"value_type": bool, "value": True}),
pytest.param({"value_type": int, "value": 0}),
pytest.param({"value_type": str, "value": "true"}),
],
indirect=True,
)
def test_validate_cond(cond_state: pc.Var):
"""Test if cond can be a pc.Val with any values

Args:
cond_state: A fixture.
"""
cond_component = Cond.create(
cond_state.value,
Text.create("cond is True"),
Text.create("cond is False"),
)

assert str(cond_component) == (
"{cond_state.value ? "
"<Text>{`cond is True`}</Text> : "
"<Text>{`cond is False`}</Text>}"
)