Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump axios version to 1.6.0 #2699

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Bump axios version to 1.6.0 #2699

merged 1 commit into from
Feb 22, 2024

Conversation

timmypidashev
Copy link
Contributor

Type of change

  • Bug fix (non-breaking change which fixes an issue)

An issue discovered in Axios 0.8.1 through 1.5.1 inadvertently reveals the confidential XSRF-TOKEN stored in cookies by including it in the HTTP header X-XSRF-TOKEN for every request made to any host allowing attackers to view sensitive information.

This bugfix bumps axios to a secure version

Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet we can probably get this into the next release. thanks.

waiting for ci pass

@timmypidashev
Copy link
Contributor Author

Since this is just an HTTP library im hoping 1.6.0 doesnt have any breaking changes with reflex, but the ci tests should show any problems 🤞

@timmypidashev
Copy link
Contributor Author

Bumped to 1.6.7 as its the current main release version, hoping that fixes the deprecation warning in this ci run

@timmypidashev timmypidashev changed the title Bump axios version to 1.6.0 Bump axios version to 1.6.7 Feb 22, 2024
@timmypidashev timmypidashev force-pushed the main branch 2 times, most recently from 86020c1 to d8d1d70 Compare February 22, 2024 21:54
@timmypidashev timmypidashev changed the title Bump axios version to 1.6.7 Bump axios version to 1.6.0 Feb 22, 2024
@timmypidashev timmypidashev requested a review from masenf February 22, 2024 22:05
@masenf masenf merged commit d698e4d into reflex-dev:main Feb 22, 2024
88 of 90 checks passed
Yummy-Yums pushed a commit to Yummy-Yums/reflex-codebase that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants