[REF-2045] Implement __reduce_ex__ for MutableProxy #2688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the object contains a MutableProxy inside of it, then we get a pickling error.
Pass through `__reduce_ex__` onto the wrapped instance to strip it off when cloudpickling to redis.
Unless the key isn't a field on the model, then it falls back to the previous behavior of just returning the given key as is... why does it do this? I don't know.
martinxu9
approved these changes
Feb 21, 2024
Yummy-Yums
pushed a commit
to Yummy-Yums/reflex-codebase
that referenced
this pull request
Feb 28, 2024
* test_state: augment modify_state test for writing MutableProxy If the object contains a MutableProxy inside of it, then we get a pickling error. * Implement __reduce_ex__ for MutableProxy Pass through `__reduce_ex__` onto the wrapped instance to strip it off when cloudpickling to redis. * base: get_value actually works with a str key Unless the key isn't a field on the model, then it falls back to the previous behavior of just returning the given key as is... why does it do this? I don't know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass through
__reduce_ex__onto the wrapped instance to strip it off when cloudpickling to redis.test_state: augment modify_state test for writing MutableProxy
If the object contains a MutableProxy inside of it, then we should not get a pickling error.
Fix #2687
Also fix
Base.get_valueto actually accept astrkey like the signature suggests... retain the existing weird behavior of passingkeyas whatever you like for backward compatibility.