Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SQLAlchemy list types #2668

Merged
merged 4 commits into from
Feb 20, 2024

Conversation

benedikt-bartscher
Copy link
Contributor

No description provided.

Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a test case would be cool too, but not strictly necessary since most of this code is already untested.

@benedikt-bartscher
Copy link
Contributor Author

@masenf I wanted to add tests later, if I have a fully working bare sqlalchemy with reflex. There are still some rough edges, f.e. with serialization, recursive/self-referencing relations and AssociationProxys. But I am getting close, most Issues are fixed in my reflex builds.
There's also #2355 which needs some love before reflex can really support bare sqlalchemy

@masenf masenf merged commit 6c49b96 into reflex-dev:main Feb 20, 2024
44 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants