Apply app theme color_mode/appearance as next-themes default #2654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masenf
changed the title
martinxu9
approved these changes
Feb 22, 2024
Yummy-Yums
pushed a commit
to Yummy-Yums/reflex-codebase
that referenced
this pull request
Feb 28, 2024
…dev#2654) * Apply app theme color_mode/appearance as next-themes default * compiler: blacken
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It still does not work with the
rx.theme_paneland default dark mode... it seems like the theme panel causes the whole app to crash; but this at least applies the default correctly all the way down and allows the default to be referenced on the frontend in case future "forcing" logic is needed.Partially address #2650