Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bug in var type for iterable types #2617

Merged
merged 4 commits into from
Feb 20, 2024

Conversation

wassafshahzad
Copy link
Contributor

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

New Feature Submission:

  • Does your submission pass the tests?
  • Have you linted your code locally prior to submission?

Description

Fixed bug with assigning var type incase of Iterable types

Linked Issue

closes #2543

Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice, people have been asking for this for a while.

Can we get a test case added? Maybe to integration/test_var_operations.py?

@wassafshahzad
Copy link
Contributor Author

Oh nice, people have been asking for this for a while.

Can we get a test case added? Maybe to integration/test_var_operations.py?

Yeah sure

@wassafshahzad
Copy link
Contributor Author

Oh nice, people have been asking for this for a while.

Can we get a test case added? Maybe to integration/test_var_operations.py?

Done

@masenf masenf merged commit 0b771db into reflex-dev:main Feb 20, 2024
44 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants