fix image serializing - REF-1889 #2550

mentally-gamez-soft · 2024-02-07T21:13:35Z

All Submissions:

Have you followed the guidelines stated in CONTRIBUTING.md file?
Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

New Feature Submission:

Does your submission pass the tests?
Have you linted your code locally prior to submission?

Changes To Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable?
Have you successfully ran tests with your changes locally?

After these steps, you're ready to open a pull request.

a. Give a descriptive title to your PR.  Issue REF-1889 - Invesatigate PIL Image serialization

b. Describe your changes. -|>  utils/serializers.py  there is no such thing as a format_mimetype property in an image object

c. Put `closes #XXXX` in your comment to auto-close the issue that your PR fixes (if such).

masenf · 2024-02-07T23:02:24Z

reflex/utils/serializers.py

@@ -319,7 +319,7 @@ def serialize_image(image: Img) -> str:
        image.save(buff, format=getattr(image, "format", None) or "PNG")
        image_bytes = buff.getvalue()
        base64_image = base64.b64encode(image_bytes).decode("utf-8")
-        mime_type = getattr(image, "get_format_mimetype", lambda: "image/png")()
+        mime_type = getattr(image, "get_format", lambda: "image/png")()


i don't think get_format is actually valid here... when i examine the resulting mime_type, it comes out as image/png, even thought the image is actually a jpeg

…rializing

Throw a warning if the image format does not have an associated MIME type and ultimately fallback to image/png and let the browser figure it out.

* fix image serializing * If get_format_mimetype does not work, look up format in Image.MIME Throw a warning if the image format does not have an associated MIME type and ultimately fallback to image/png and let the browser figure it out. * test_media: end to end serialization of PIL images --------- Co-authored-by: Masen Furer <[email protected]>

fix image serializing

845f0b6

masenf requested changes Feb 7, 2024

View reviewed changes

masenf added 3 commits February 21, 2024 12:41

Merge remote-tracking branch 'origin/main' into fix-REF-1889-image-se…

e00008f

…rializing

If get_format_mimetype does not work, look up format in Image.MIME

519878e

Throw a warning if the image format does not have an associated MIME type and ultimately fallback to image/png and let the browser figure it out.

test_media: end to end serialization of PIL images

47f3280

picklelo approved these changes Feb 22, 2024

View reviewed changes

masenf approved these changes Feb 22, 2024

View reviewed changes

masenf merged commit 278183b into reflex-dev:main Feb 22, 2024
44 of 45 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix image serializing - REF-1889 #2550

fix image serializing - REF-1889 #2550

mentally-gamez-soft commented Feb 7, 2024 •

edited

Loading

masenf Feb 7, 2024

fix image serializing - REF-1889 #2550

fix image serializing - REF-1889 #2550

Conversation

mentally-gamez-soft commented Feb 7, 2024 • edited Loading

All Submissions:

Type of change

New Feature Submission:

Changes To Core Features:

After these steps, you're ready to open a pull request.

masenf Feb 7, 2024

Choose a reason for hiding this comment

mentally-gamez-soft commented Feb 7, 2024 •

edited

Loading