Shorten no-referrer GitHub URLs too #33
Conversation
Co-authored-by: Federico Brigante <[email protected]>
|
Yeah it doesn't because those links are usually shortened natively. To properly add support for refined-github/refined-github#4981 the regular issues should also work. The example URL in that issue isn't shortened |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Ideally this should support issues and PRs even without isRedirection, to both work as a general-purpose shortener (rather than extension-specific) and to (I think) support comment links like
Currently isRedirection does not display that (comment)/(review) part
However non-isRedirection support isn't required for this PR.
fregante
changed the title
fregante
changed the title
| @@ -4,7 +4,9 @@ const patchDiffRegex = /[.](patch|diff)$/; | |||
| const releaseRegex = /^releases[/]tag[/]([^/]+)/; | |||
| const labelRegex = /^labels[/]([^/]+)/; | |||
| const compareRegex = /^compare[/]([^/]+)/; | |||
| const pullRegex = /^pull[/](\d+)[/]([^/]+)(?:[/]([\da-f]{40})[.][.]([\da-f]{40}))?$/; | |||
| const pullRegex = /^pull[/](\d+)(?:[/]([^/]+))?(?:[/]([\da-f]{40})[.][.]([\da-f]{40}))?$/; | |||
There was a problem hiding this comment.
It'd be good to use named groups here to describe what each group is capturing, even if unused. What do you think?
|
You can open a PR with the same title on refined GitHub and install just this dependency |
Fixes refined-github/refined-github#4981