Skip to content
This repository has been archived by the owner on Aug 26, 2022. It is now read-only.

Updates Flash Messaging Bus doc for react-hot-toast #608

Merged
merged 5 commits into from
Mar 11, 2021

Conversation

cannikin
Copy link
Member

@cannikin cannikin commented Mar 4, 2021

To be merged once redwoodjs/redwood#1856 is released

@cannikin
Copy link
Member Author

cannikin commented Mar 5, 2021

Thanks @jtoar!

cannikin and others added 2 commits March 7, 2021 08:49
@cannikin
Copy link
Member Author

cannikin commented Mar 7, 2021

Did we merge @Tobbe's suggestion of just exporting * from react-hot-toast? In that case we need to update these import statements to use toast as the default:

import toast, { Toaster } from '@redwoodjs/web/toast'

@thedavidprice thedavidprice merged commit 10fd78b into main Mar 11, 2021
@thedavidprice thedavidprice deleted the rc-toast-docs branch March 11, 2021 07:34
@thedavidprice
Copy link
Contributor

@cannikin I merged this since the release is out. I don't have an answer about exporting all the things ¯_(ツ)_/¯

@Tobbe
Copy link
Member

Tobbe commented Mar 11, 2021

@thedavidprice @cannikin

TL;DR: The doc is correct 👍

We have this

export { default as toast } from 'react-hot-toast'
export * from 'react-hot-toast'

So the import should be like this, which is what we have here

import { toast, Toaster } from '@redwoodjs/web/toast'

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants