fix(cli): Remove boxen from default error output #9568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Much more forgiving for resizing the terminal! 👍 Initial: Wider: More narrow: |
Tobbe
approved these changes
Nov 21, 2023
jtoar
pushed a commit
that referenced
this pull request
Nov 29, 2023
**Problem** There are too many cases where using boxen for the default error output causes readability issues. **Change** 1. Remove boxen and simply draw a few straight lines coloured with chalk. This should avoid the readability issues. **Example** <img width="1155" alt="image" src="https://github.com/redwoodjs/redwood/assets/56300765/db01fdad-76e2-4a1a-a23e-da83d032e36e"> **Context** The reason this exists in the first place was to try and centralise the error output. There were so many places in the CLI code where errors are output in various different styles which is not necessarily the best experience.
jtoar
pushed a commit
that referenced
this pull request
Nov 29, 2023
**Problem** There are too many cases where using boxen for the default error output causes readability issues. **Change** 1. Remove boxen and simply draw a few straight lines coloured with chalk. This should avoid the readability issues. **Example** <img width="1155" alt="image" src="https://github.com/redwoodjs/redwood/assets/56300765/db01fdad-76e2-4a1a-a23e-da83d032e36e"> **Context** The reason this exists in the first place was to try and centralise the error output. There were so many places in the CLI code where errors are output in various different styles which is not necessarily the best experience.
jtoar
pushed a commit
that referenced
this pull request
Nov 29, 2023
**Problem** There are too many cases where using boxen for the default error output causes readability issues. **Change** 1. Remove boxen and simply draw a few straight lines coloured with chalk. This should avoid the readability issues. **Example** <img width="1155" alt="image" src="https://github.com/redwoodjs/redwood/assets/56300765/db01fdad-76e2-4a1a-a23e-da83d032e36e"> **Context** The reason this exists in the first place was to try and centralise the error output. There were so many places in the CLI code where errors are output in various different styles which is not necessarily the best experience.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There are too many cases where using boxen for the default error output causes readability issues.
Change
Example
Context
The reason this exists in the first place was to try and centralise the error output. There were so many places in the CLI code where errors are output in various different styles which is not necessarily the best experience.