Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(router): Add missing tests in analyze routes #9274

Merged
merged 4 commits into from
Oct 12, 2023

Conversation

dac09
Copy link
Contributor

@dac09 dac09 commented Oct 6, 2023

As title:
In #9204 we missed some tests we were meant to have ;)

@dac09 dac09 changed the title fix(router): Fix missing tests in analyze routes chore(router): Add missing tests in analyze routes Oct 6, 2023
@dac09 dac09 requested a review from KrisCoulson October 6, 2023 08:16
@dac09 dac09 force-pushed the chore/cleanup-routing-stuff branch from 95e2ea9 to 97aa369 Compare October 6, 2023 08:16
@dac09 dac09 added this to the next-release-patch milestone Oct 9, 2023
@dac09 dac09 added the release:chore This PR is a chore (means nothing for users) label Oct 9, 2023
@jtoar jtoar modified the milestones: next-release-patch, chore Oct 10, 2023
@jtoar
Copy link
Contributor

jtoar commented Oct 10, 2023

quick clarification: #9024 is a Docker PR. did you mean something else or is this related to Docker?

@dac09
Copy link
Contributor Author

dac09 commented Oct 10, 2023

quick clarification: #9024 is a Docker PR. did you mean something else or is this related to Docker?

whoops meant #9204

@dac09 dac09 enabled auto-merge (squash) October 12, 2023 05:04
@dac09 dac09 merged commit 3ed46ec into redwoodjs:main Oct 12, 2023
@Josh-Walker-GM Josh-Walker-GM modified the milestones: chore, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants