feat(mailer): Resend handler #9175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dthyresson
reviewed
Sep 18, 2023
| // I was not having success at passing attachment contents as strings directly | ||
| // to the Resend client, so I'm going to transform them to Buffers if they are | ||
| // strings. | ||
| const transformedAttachments = [] |
There was a problem hiding this comment.
Do you think other mail handlers will have a similar need? If so, break out into a util function? Can do that refactor later perhaps, unless easier to test individual function to convert.
There was a problem hiding this comment.
Not sure. In theory resend allows the string type but passing them in directly was confusing when it was malformed in my basic tests.
Happy to either extract it out or even change the interface (not user facing but handler facing) to adapt to what we find more convenient as we add more handlers.
There was a problem hiding this comment.
Ah, ok. Let's refactor/revisit when implementing other handlers like Postmark, etc etc
|
@Josh-Walker-GM approved and good to merge |
jtoar
pushed a commit
that referenced
this pull request
Sep 19, 2023
**Description** This is intended to be a mail handler which specifically uses the [resend node sdk](https://github.com/resendlabs/resend-node/tree/main). **Changes** 1. Adds a new resend mail handler which uses the resend node sdk to send mail. 2. Removes an unneeded `uuid` dependency from the in-memory mail handler. I noticed this when copying over the handler as a template for this new one. **Notes** 1. I had to add a transformation of the attachment contents when they were passed as a string. If I did not transform them into a buffer then the attachment content would be malformed during my testing. 2. I have tested this manually but for the moment there is no specific testing suite/strategy in place to test these mail handlers/renderers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is intended to be a mail handler which specifically uses the resend node sdk.
Changes
uuiddependency from the in-memory mail handler. I noticed this when copying over the handler as a template for this new one.Notes