chore(v6): change to React automatic runtime #8926
Conversation
|
My use case is I'm using https://theme-ui.com. When I switched to using Vite as the bundler in my project theme-ui stopped working. Our Vite configuration is already using the new(ish) automatic runtime. Bringing Webpack up to this as well will make it easier for users who decide to stay on Webpack for now to change to Vite later when we decide to stop supporting Webpack. |
| name: "editJob"`) | ||
| expect(outputNoStaticImports).toContain( | ||
| normalizeStr( | ||
| `}), /*#__PURE__*/(0, _jsxRuntime.jsx)(_router.Route, { |
There was a problem hiding this comment.
The main difference in these tests is that they look for /*#__PURE__*/(0, _jsxRuntime.jsx) instead of .createElement
| function normalizeStr(str: string) { | ||
| return str | ||
| .split('\n') | ||
| .map((line) => line.trim()) | ||
| .join('\n') | ||
| .trim() | ||
| } |
There was a problem hiding this comment.
I was getting failures for what I could only assume was spacing, so after some trial and error where I'd add a space or a tab (which I entertained for too long), I just decided to normalize everything
This change is a long time coming (~three years... https://legacy.reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.html) and is a change that our v6 Vite config already makes. The post I linked to above explains the change well and **I recommend reading it**. But here's an example of the difference in dist output: <img width="2012" alt="image" src="https://github.com/redwoodjs/redwood/assets/32992335/7f1a6e38-42c1-407f-8317-8a8ceb7ce672"> Note that if a user has custom React preset config, this PR has no affect, making it less worrisome to add to a release. @Tobbe I know we discussed earlier, but remind me what the motivation for this change was? That modern tools rely on it right? Here's the Babel docs for completeness: https://babeljs.io/docs/babel-plugin-transform-react-jsx
This change is a long time coming (~three years... https://legacy.reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.html) and is a change that our v6 Vite config already makes.
The post I linked to above explains the change well and I recommend reading it. But here's an example of the difference in dist output:
Note that if a user has custom React preset config, this PR has no affect, making it less worrisome to add to a release.
@Tobbe I know we discussed earlier, but remind me what the motivation for this change was? That modern tools rely on it right?
Here's the Babel docs for completeness: https://babeljs.io/docs/babel-plugin-transform-react-jsx