rw upgrade: Update package versions from template package.json #8855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtoar
approved these changes
Jul 7, 2023
jtoar
pushed a commit
that referenced
this pull request
Jul 7, 2023
Currently when running `yarn rw upgrade -t canary` we're only upgrading RW package versions. If other packages that are listed in our create-redwood-app template package.jsons are upgraded the `rw upgrade` command won't catch that. So running `yarn rw upgrade -t canary` might not give you the same versions of packages as if you used a canary version of `yarn create redwood-app`. I remember this being a problem when we upgraded React from v17 to v18. And now it's a problem again when we've upgraded to a canary version of React. So now when running `yarn rw upgrade -t canary` the upgrade command will download the `package.json` files from our template and get the versions of packages from in there. Currently this is only done for canary, but we can (probably/hopefully) enable it for other versions too if this is something we want to do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when running
yarn rw upgrade -t canarywe're only upgrading RW package versions.If other packages that are listed in our create-redwood-app template package.jsons are upgraded the
rw upgradecommand won't catch that.So running
yarn rw upgrade -t canarymight not give you the same versions of packages as if you used a canary version ofyarn create redwood-app.I remember this being a problem when we upgraded React from v17 to v18.
And now it's a problem again when we've upgraded to a canary version of React.
So now when running
yarn rw upgrade -t canarythe upgrade command will download thepackage.jsonfiles from our template and get the versions of packages from in there.Currently this is only done for canary, but we can (probably/hopefully) enable it for other versions too if this is something we want to do.