-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Storybook Template files to for CSF 3 #8788
Conversation
packages/cli/src/commands/generate/cell/templates/stories.js.template
Outdated
Show resolved
Hide resolved
@jtoar Is there a way to test the generators? |
@ahaywood you can always use
If you make any changes, you'll have to build again. Here's a short video that shows what I mean a little more clearly: https://www.loom.com/share/bcd664c6de4d40fa8229767440657231 |
@jtoar I updated the cell story and tested everything in a TS and JS project. Ready for your review. |
- rm semi colons - newlines - no space in braces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ahaywood! This is more than enough for the v6 RC. Two small comments and this is good to merge after we update the snapshots for the tests.
packages/cli/src/commands/generate/cell/templates/stories.tsx.template
Outdated
Show resolved
Hide resolved
packages/cli/src/commands/generate/cell/templates/stories.tsx.template
Outdated
Show resolved
Hide resolved
…template Co-authored-by: Dominic Saadi <[email protected]>
…template Co-authored-by: Dominic Saadi <[email protected]>
[Notion Task](https://www.notion.so/redwoodjs/generators-to-CSF-3-444966a53e5a462eab5d4c3f093ebbb3?pvs=4) ## Feature description Updated storybook stories for CSF 3 - Updated stories for cells, components, layouts, and pages Tested TypeScript - [x] cells - [x] components - [x] layouts - [x] pages Tested JavaScript - [x] cells - [x] components - [x] layouts - [x] pages
This updates the test-project rebuild script to be aligned with the changes introduced in #8788
This updates the test-project rebuild script to be aligned with the changes introduced in #8788
Notion Task
Feature description
Updated storybook stories for CSF 3
Tested TypeScript
Tested JavaScript