Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cli-plugins): remove project file from sb command #8626

Merged
merged 1 commit into from
Jun 15, 2023
Merged

chore(cli-plugins): remove project file from sb command #8626

merged 1 commit into from
Jun 15, 2023

Conversation

jtoar
Copy link
Contributor

@jtoar jtoar commented Jun 15, 2023

Follow up to #8581; removes the src/lib/project.ts file from the storybook CLI plugin. This also means we don't have to list lodash as a dep here.

@jtoar jtoar added the release:chore This PR is a chore (means nothing for users) label Jun 15, 2023
@jtoar jtoar added this to the v6.0.0 milestone Jun 15, 2023
@jtoar jtoar requested a review from Josh-Walker-GM June 15, 2023 18:39
@jtoar Pullflow.com
Copy link
Contributor Author

jtoar commented Jun 15, 2023

Follow up to #8581; removes the src/lib/project.ts file from the storybook CLI plugin. This also means we don't have to list lodash as a dep here.

Josh-Walker-GM
Josh-Walker-GM approved these changes Jun 15, 2023
View reviewed changes
Copy link
Collaborator

@Josh-Walker-GM Josh-Walker-GM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jtoar jtoar merged commit 358993a into main Jun 15, 2023
@jtoar jtoar deleted the ds-cli-plugins/remove-project-file-from-sb-command branch June 15, 2023 19:48
@redwoodjs-bot redwoodjs-bot bot modified the milestones: v6.0.0, next-release Jun 15, 2023
@jtoar jtoar modified the milestones: next-release, v6.0.0 Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Walker-GM Josh-Walker-GM Josh-Walker-GM approved these changes

Assignees
No one assigned
Labels
release:chore This PR is a chore (means nothing for users)
Projects
None yet
Milestone
v6.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jtoar @Josh-Walker-GM