Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CI): test webpack in the smoke tests #8604

Merged
merged 6 commits into from
Jun 14, 2023
Merged

Conversation

jtoar
Copy link
Contributor

@jtoar jtoar commented Jun 13, 2023

Complementary PR to #8602 that does the same but for the smoke tests. This was also pretty straightforward and used basically the same strategy as that PR. We're back to running a lot of tests, but that's just the way it goes I guess.

@jtoar jtoar added the release:chore This PR is a chore (means nothing for users) label Jun 13, 2023
@jtoar jtoar requested a review from thedavidprice June 13, 2023 21:37
Copy link
Contributor

@thedavidprice thedavidprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it once it's passing 🚢

@jtoar
Copy link
Contributor Author

jtoar commented Jun 13, 2023

Don't merge this yet—judging by the logs I don't think it's working yet resolved

@jtoar jtoar merged commit 2f1d427 into main Jun 14, 2023
@jtoar jtoar deleted the ds-ci/smoke-tests-webpack branch June 14, 2023 02:18
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Jun 14, 2023
@jtoar jtoar modified the milestones: next-release, v6.0.0 Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants