Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix await import in auth setup #8582

Merged
merged 1 commit into from
Jun 10, 2023
Merged

Fix await import in auth setup #8582

merged 1 commit into from
Jun 10, 2023

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Jun 10, 2023

This is most likely a regression from #8456

@Tobbe Tobbe marked this pull request as ready for review June 10, 2023 16:41
@Tobbe Tobbe added the release:fix This PR is a fix label Jun 10, 2023
@jtoar jtoar added the fixture-ok Override the test project fixture check label Jun 10, 2023
jtoar
jtoar approved these changes Jun 10, 2023
View reviewed changes
Copy link
Contributor

@jtoar jtoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch @Tobbe!

@jtoar jtoar merged commit 7b038f8 into redwoodjs:main Jun 10, 2023
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Jun 10, 2023
@Tobbe Tobbe deleted the tobbe-await-import-auth-setup-fix branch June 11, 2023 12:09
jtoar pushed a commit that referenced this pull request Jun 22, 2023
@Tobbe @jtoar
Fix await import in auth setup (#8582)
38cfef8
@jtoar jtoar modified the milestones: next-release, v5.4.0 Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtoar jtoar jtoar approved these changes

Assignees
No one assigned
Labels
fixture-ok Override the test project fixture check release:fix This PR is a fix
Projects
None yet
Milestone
v5.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Tobbe @jtoar